Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for corrupted Nortek files #372

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jmcvey3
Copy link
Contributor

@jmcvey3 jmcvey3 commented Jan 9, 2025

If a datafile is filled with bad bytes, the reader will get stuck in one of two while loops.

@jmcvey3 jmcvey3 requested a review from akeeste January 9, 2025 18:29
@akeeste akeeste linked an issue Jan 9, 2025 that may be closed by this pull request
@akeeste
Copy link
Contributor

akeeste commented Jan 9, 2025

@jmcvey3 Using the sample file I sent you, this fix gets past the previous sticking point in #370 (_NortekReader initialization), but now gets stuck at _NortekReader.readfile(). Is there another check you can add that will break the while loops in _NortekReader.readfile() and/or _NortekReader.findnext()?

@jmcvey3
Copy link
Contributor Author

jmcvey3 commented Jan 14, 2025

@jmcvey3 Using the sample file I sent you, this fix gets past the previous sticking point in #370 (_NortekReader initialization), but now gets stuck at _NortekReader.readfile(). Is there another check you can add that will break the while loops in _NortekReader.readfile() and/or _NortekReader.findnext()?

How long did you let it run for, and what is listed in the .dolfyn.log? It took a good 5 or 10 minutes for dolfyn to cycle through every byte of the file to try and find valid data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOLfYN reading a .VEC file indefinitely
2 participants