Bug: Shell-Exec tick does not gets updated after allowing/disallowing it on demand

[Vankog]

This seems to happen at least for the function Shell-Exec. On other functions it seems to work, but I haven't tested out all functions available.

1. e.g. app "Adaway": restrict (or unrestrict) Shell-Exec and enable the on-demand dialog for this function.
2. run the app
3. allow (or disallow) the function in the pop-up dialog (not for the whole category)
4. return to the applications restrictions list in XPrivacy
5. The selection of the function has not changed - it is still restricted (or unrestricted). However, it seems to be applied properly, because the restriction that was chosen in the dialog is still active.

May also appear with some other functions or with the "apply for whole category" option enabled, but I haven't checked for it all.

[M66B]

I have tried several times, but I cannot reproduce this. Are you using the latest version of XPrivacy?

[Vankog]

@M66B
Hm strange...
Yes I do. 2.0.1
I was able to reproduce it yesterday and today while writing the issue. With multiple reboots in between.
Strangely enough, the ticks of other functions do work correctly.

---

I found another app: "Android Tuner" by 3c
The same scenario and with the same result.
Maybe its just a simple UI issue?

---

My first idea was: Maybe it's because its the first entry in the category.
However, View-WebView works correctly.

The next idea: Maybe its a display error due to the black theme. I switched it with no success.

The next idea: Maybe its the category at all.
And here seems to be the problem indeed. I've tried it with Shell-LoadLibrary on another app and it shows the same issue.

So the Shell category seems to display incorrectly after choosing on-demand restrictions.

Further, I also ruled out possible interferences with the template by trying several combinations.

---

My global app settings:
restrict on demand - true
show usage data - true
no parameters
no debug
expert mode - true
restrict system- true
restrict dangerous - nope
secure connection - true
randomize on boot - true
no further randomize on access

Category Shell is set to restricted in the template.

System: Galaxy Nexus (maguro) on Stock 4.1.1 rooted

[M66B]

It was quite a search, but this version should fix the problem: http://d-h.st/8c0
Could you please test it thoroughly and let me know if it does fix the problem?
Please also check if there are no double on demand questions now.

[Vankog]

Wow, thank you for this amount of effort!
It really seems to work now.

And you also fixed that the SU request was filed as Exec request.
I was curious about this too, because the Exec call was actually referencing the SU, but I was not sure if this was really a bug or just a quirk.

So, great work!