Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Wilcards in White/Blacklists #1474

Closed
an0n981 opened this issue Feb 28, 2014 · 12 comments
Closed

Wilcards in White/Blacklists #1474

an0n981 opened this issue Feb 28, 2014 · 12 comments

Comments

@an0n981
Copy link
Contributor

an0n981 commented Feb 28, 2014

In White/Blacklists the wildcards () don't function the way wildcards usually do.
If I whitelist for example /sdcard/folder1/
anything in folder1 should be whitelisted. Howevever, if the destination is more than 1 subfolder away from folder1 (i.e. /sdcard/folder1/x/y) the wildcard rule does not apply.
The same goes for domains where *.google.com should also block abc.123.google.com

I hope this makes sense

@M66B
Copy link
Owner

M66B commented Feb 28, 2014

How do you propose to solve this in a for everybody transparent way?

@M66B
Copy link
Owner

M66B commented Feb 28, 2014

Please not that there would be a significant performance impact for checking multiple levels, so that is not an option.

@an0n981
Copy link
Contributor Author

an0n981 commented Feb 28, 2014

If checking multiple levels is not an option then I am all out of ideas :( Since that is exactly what wildcards are for

@Cerberus-tm
Copy link

In theory, you could allow a user to switch between two whitelist/blacklist modes:

  1. Static but recursive: the list of whitelisted files is only updated when you tap a button in Xprivacy. So when a new file is created in a subfolder, the whitelist will not know about it, until you go to the whitelist settings again to update the list.
  2. Live but superficial: only the upper folder is checked for files to be whitelisted, but it happens every time the application tries to access files.

Or perhaps a combination of these modes. But I'm not sure this should have priority... I don't think it would matter to me, for now.

@M66B
Copy link
Owner

M66B commented Feb 28, 2014

I see no feasible solution to fix this, so I am setting this issue to won't fix.

@M66B M66B closed this as completed Feb 28, 2014
@M66B M66B added the wontfix label Feb 28, 2014
@Cerberus-tm
Copy link

I completely agree and understand.

@M66B
Copy link
Owner

M66B commented Jun 28, 2014

I will see what I can do again.

@M66B M66B reopened this Jun 28, 2014
@M66B M66B closed this as completed in fa4024b Jun 28, 2014
@M66B
Copy link
Owner

M66B commented Jun 28, 2014

M66B added a commit that referenced this issue Jun 28, 2014
@M66B
Copy link
Owner

M66B commented Jun 28, 2014

This version should shown one level of folders more:
https://crowd.xprivacy.eu/XPrivacy_2.1.13-4.apk

@an0n981
Copy link
Contributor Author

an0n981 commented Jun 28, 2014

This new version works great, but it may cause issues on devices with small screens. I just had a popup that took up the whole screen on my note 2 with a large screen

@M66B
Copy link
Owner

M66B commented Jun 28, 2014

The on demand dialog is scrollable.
You can try it by rotating your device 90 degrees.

@an0n981
Copy link
Contributor Author

an0n981 commented Jun 28, 2014

Learn something new every day

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants