Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some China commercial map service to ban list #1

Open
LaoshuBaby opened this issue Jan 11, 2022 · 7 comments
Open

Add some China commercial map service to ban list #1

LaoshuBaby opened this issue Jan 11, 2022 · 7 comments

Comments

@LaoshuBaby
Copy link
Contributor

I was suprised by this addon, great!

I hope it can affect on more commercial map service and replace them all to OSM, here is a list of famous TMS service in China (but not everyone is commercial), I suggest to ban those "Gaode" and "Baidu" 2 service in osm-everywhere.

(Those 2 map service have been add to iD Editor's validator since openstreetmap/iD#8701)

@M-Reimer
Copy link
Owner

Sorry but this won't help me. What I actually need are some pages where their map service is used for testing and for analyzing how the URLs actually look like if used.

And I would even more prefer if someone from China would have a look into this. I don't know about popular pages using maps in China. Here in Germany this is much easier for me. For example every big supermarket chain provides a map with their locations. So for my needs it was a good start to get all the supermarket location maps remapped to OSM to have a pretty good coverage.

@LaoshuBaby

This comment was marked as off-topic.

@M-Reimer
Copy link
Owner

Can you please provide me with some chinese example pages? Maybe a few popular chinese shops which provide a map to find their locations? I tried but I'm not able to efficiently search for chinese websites.
If no one can provide any information that helps me, then I guess the request is not that important and it will be closed in two weeks.

@LaoshuBaby

This comment was marked as off-topic.

@M-Reimer
Copy link
Owner

M-Reimer commented Oct 31, 2022

I do not replace tiles directly on the "provider website" (the website actually providing the map service). Doing so makes it difficult for OSM mappers to "have a look" at other map services.

So what I need is an external embed. For example a shop site using one of the commercial map services. Better two known map users per service.

@LaoshuBaby
Copy link
Contributor Author

LaoshuBaby commented Oct 31, 2022

If you means third party website that embedded those map service, looks at those example, they are raster. Is this helpful?

Baidu map

Here is a encyclopedia website that will show many aspect of a museum, it given user a map as transport guide:

https://baike.baidu.com/item/%E5%8C%97%E4%BA%AC%E6%95%85%E5%AE%AB/345415?fromModule=search-result_lemma#9_4

图片

Gaode map

A job hiring website that use gaode's map show company's address:

https://www.zhipin.com/gongsi/7d67b198abe5e86c1Hx9098~.html

图片

(I research Gaode's document found that it only use raster tiles when WebGL is disabled

I'm a firefox user so I change webgl.disabled=true in about:config

@M-Reimer
Copy link
Owner

M-Reimer commented Nov 1, 2022

Thanks for providing these.

(I research Gaode's document found that it only use raster tiles when WebGL is disabled

That's an interesting find. Google Maps has a similar feature. They also load tiles in some proprietary format on their own website (which very likely is some kind of "vector tile") but at least all "external users", I tried so far, still used raster tiles (but don't have to. They can opt into vector tiles if they want). Google also describes vector tiles as a "WebGL feature". I wonder if they also fall back to raster if WebGL is missing.

Of course it is not really an option to ask all users to disable WebGL as this is used for more things and you would considerably reduce the features of a modern browser. But I already have listeners that hook into web requests so it could be an option to also hook into the actual javascript file load and patch 'getContext("webgl")' to something like 'getContext("some_invalid_context")' to make WebGL detection for the map service always fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants