Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internals update request #65

Open
resistancelion opened this issue Jun 20, 2021 · 2 comments
Open

Internals update request #65

resistancelion opened this issue Jun 20, 2021 · 2 comments

Comments

@resistancelion
Copy link

resistancelion commented Jun 20, 2021

Update internals for classes:
Modding

  • (+) RescanModsFolder() or RefreshAvailableModsList()
    as it says, refresh available mods - scan folder for subfolders/*.civ5mod files
  • (+) RefreshSubscribedModsList()
    scan for new available to download mods from previous scan or DB update and download if possible
  • (+) ResetDatabase()
    clean mods cache database without erasing user settings (created by Modding.SetSystemProperty)
  • (+) string GetCachePath()
    return user-related game cache path

ModDetails (properties)

  • (+) true|false SupportsMac
  • (+) true|false SupportsHotSeat
  • (+) string Categories
    return categories to which it mod belongs, separated by commas

It will fix some bugs and add new filtering possibilities, but there's still one confusing bug with the mod database, after mod's .modinfo file is edited, game recognizes the mod as new, which leads to another:

  1. The mod will be deactivated
  2. The gamesave will no longer load, instead causing crash after attemption to load it with this mod

When testing i didn't edit mod id or name, so it must be related to hash routines.

@Personwithhat
Copy link

This sounds good, would help some issues.
Maybe also automatically detect mods that require updates on start, and give some kind of a notification.
Have to bother people to check Mods>Scroll to mod > Check if 'Update' button is there

And then of course constantly hit issues such as:

  • Subscribed to mod, but it doesn't download. Have to delete all other mods to get it to recognize it needs to be downloaded.
  • Mod has had an update but update button doesn't appear

Random caching issue is my guess.

@resistancelion
Copy link
Author

This sounds good, would help some issues. Maybe also automatically detect mods that require updates on start, and give some kind of a notification. Have to bother people to check Mods>Scroll to mod > Check if 'Update' button is there

And then of course constantly hit issues such as:

  • Subscribed to mod, but it doesn't download. Have to delete all other mods to get it to recognize it needs to be downloaded.
  • Mod has had an update but update button doesn't appear

Random caching issue is my guess.

Exactly, by the time i was writing it i was modifying UI & functionality of the mods window, i've got it to work with filters, added ability to use & create modlist(modpack) files and a few fixes.
But i do not reach my main goal - to make it work on Linux, Linux version of the game just reject any content that i try to add either as the mod or as the fake DLC, neither i could get to work regular modification or such of my own.

Also, @Lymia can we discuss modding & your particular creation on any social network or by e-mail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants