Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log linear, MLP, RNN use invalid default values #226

Open
bpopeters opened this issue Jul 16, 2024 · 0 comments
Open

Log linear, MLP, RNN use invalid default values #226

bpopeters opened this issue Jul 16, 2024 · 0 comments

Comments

@bpopeters
Copy link
Contributor

It makes no sense to specify input=None or output=None in the headers of the various models' functions, as these arguments are in fact required and the models fail if they are unspecified.

Additionally, input and output are not good choices for variable names -- input because it shadows a builtin and output because it is not an accurate description of what is does -- it is actually the gold label, not the output of any model. Personally I'm partial to X and y because they're simple and are closer to the math.

PR coming in 10 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant