Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Button component variants #470

Open
4 tasks
IsaDavRod opened this issue Dec 31, 2024 · 0 comments
Open
4 tasks

Modify Button component variants #470

IsaDavRod opened this issue Dec 31, 2024 · 0 comments
Assignees

Comments

@IsaDavRod
Copy link
Member

IsaDavRod commented Dec 31, 2024

Modify the existing button component to add new variants minimal/small, proper gap and padding using our new spacing system.

#464 PR implemented the spacing token system. It essentially ensures padding/margins between edges or elements are using consistent values. Read more about the 4px grid system.

src/shared/types/Spacing.ts

export const spacing = {
    'spacing-1': '.125rem',
    'spacing-2': '.25rem',
    'spacing-3': '.5rem',
    'spacing-4': '.75rem',
    'spacing-5': '1rem',
    'spacing-6': '1.25rem',
    'spacing-7': '1.5rem',
    'spacing-8': '2rem',
} as const;

Above are all the px values that are used consistently throughout each Figma component and layout for padding and gaps. (ofc use rem if that is how yall do it in the codebase)

See the Figma button component in Dev Mode to read my annotations and properties that I have highlighted for some variants: https://www.figma.com/design/8tsCay2FRqctrdcZ3r9Ahw/UT-Registration-Plus?node-id=1008-9767&m=dev

  • Ignore the button states (hover, pressed, disabled) However, for the new variants (small/minimal) just use the same state properties as used in existing buttons.
  • Add new variants
  • Ensure spacing system is used for padding and gaps
  • Ensure all other properties of each button variant in your PR is consistent with the button properties in the Figma

Note: You must be invited to the Figma with view permissions to see annotations in Dev Mode

@IsaDavRod IsaDavRod converted this from a draft issue Dec 31, 2024
@IsaDavRod IsaDavRod moved this from Ready to Backlog in UTRP Development Tracker Dec 31, 2024
@IsaDavRod IsaDavRod moved this from Backlog to Ready in UTRP Development Tracker Dec 31, 2024
@IsaDavRod IsaDavRod moved this from Ready to In progress in UTRP Development Tracker Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

2 participants