Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history_thin does not affect returned samples and log_ps in core.run_dream() #28

Open
jfgallimo opened this issue Aug 26, 2022 · 0 comments

Comments

@jfgallimo
Copy link

It may be by design, but history_thin does not thin the results returned by run_dream(). As a result, history_thin does not ameliorate memory issues that affect large runs, i.e., large niterations.

I was able to solve the problem by hacking core._sample_dream (or at least I think I solved it). I pass the variable step_instance.history_thin as a fifth argument and modified the array allocation of sampled_params and log_ps. Accordingly, I also ensure that sampled params and log_ps are updated only every history_thin iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant