Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion between likelihood and log likelihood #23

Open
noashin opened this issue Jul 7, 2020 · 1 comment
Open

Confusion between likelihood and log likelihood #23

noashin opened this issue Jul 7, 2020 · 1 comment

Comments

@noashin
Copy link

noashin commented Jul 7, 2020

One of the parameters of pydream.core.run_dream is called "likelihood" and the documentation specify it to be "A user-defined likelihood function".

It seems though that the code is actually expecting a log-likelihood function, as seen in pydream.model.total_logp line 30:

loglike = self.likelihood(q0)

This can be easily solved by changing the parameter name to be log_likelihood and changing the documentation accordingly.

@ortega2247
Copy link
Contributor

You are right. Thanks for pointing it out. We will be updating the parameter name and the documentation accordingly.

Best,
Oscar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants