Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Rendering #2

Open
ReignOfComputer opened this issue Dec 25, 2022 · 9 comments
Open

iOS Rendering #2

ReignOfComputer opened this issue Dec 25, 2022 · 9 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ReignOfComputer
Copy link

ReignOfComputer commented Dec 25, 2022

Hi, just wondering if the page titles are rendering correctly on iOS/WebKit based devices? Seems the title font (mctit) doesn't render correctly when I try it out.

Edit: I played around the CSS and found that removing the transform the webkit variants from the h1 css fixes this issue. Webkit always has such weird quirks with fonts, sigh.

@JulianPrieber
Copy link
Member

@lastsamurai26 could you look into this?

@JulianPrieber JulianPrieber added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Dec 26, 2022
@lastsamurai26
Copy link
Member

Sure

@ReignOfComputer
Are you using our latest LCC version and the latest theme version ?

Can you please tell me which Apple OS you are using ?

I'm currently running MacOS Ventura and iOS 16.2 on Safari.

All browsers are already covered in the code.
It may be that in the meantime the order no longer fits because Safari on Apple
-webkit-transform is no longer needed and we have to move it to another place.

This is the code from the theme itself

    -webkit-transform: perspective(300px) rotateX(15deg);
    -moz-transform: perspective(300px) rotateX(15deg);
    -ms-transform: perspective(300px) rotateX(15deg);
    -o-transform: perspective(300px) rotateX(15deg);
    transform: perspective(300px) rotateX(15deg);

can you show me as a picture what exactly does not fit.
Have the theme installed me times and can only determine that the headline takes a while to create

@ReignOfComputer
Copy link
Author

I'm using the latest downloadable LLC version from the llc-themes repo.

I just setup a fresh install, which can be found at: https://links-staging.reignofcomputer.com/

Desktop View

iOS Edge

iOS Safari

@lastsamurai26
Copy link
Member

ok, I could reproduce the problem in the meantime, but when removing -webkit- from the code, the theme is still not displayed correctly, which can have different causes. What makes me wonder is that the error occurs under Safari 15.6.1 but under 16.1 it is sometimes there and sometimes not.

Can you install Chrome under ios and MacOS?
Edge should not have the error because this is based on Chromium does.
Both Chrome and Edge use the same engine.
AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36 Edg/108.0.1462.54
so the error should be present under Chrome and also Edge and not only edge and safari under Mac or iOS

Which version do you use ?

@ReignOfComputer
Copy link
Author

AFAIK, all iOS browsers are Safari, regardless of what they call themselves.

FWIW, issue is still present on Chrome iOS.

My fix was to remove the non-browser specific transform:. Not ideal, but it got the title to render.

@lastsamurai26
Copy link
Member

I looked at this again, but unfortunately I can't get the font to display despite deleting the non-browser specific settings.

-webkit
-ms etc I have removed

Which makes me wonder why we didn't notice the error before.

I have installed Chrome on the Ipad and on the Iphone and I can not reproduce this error there.
only under Safari.
@JulianPrieber can you reproduce that under Safari the font appears briefly and then disappears again ?

Bildschirmaufnahme.2022-12-29.um.09.43.31.mp4

@ReignOfComputer
Copy link
Author

Hmm, no luck on this?

@lastsamurai26
Copy link
Member

not yet, get do you a Solution?

i tried many things

@ReignOfComputer
Copy link
Author

As before, my workaround is to change:

    -webkit-transform-origin: 50% 100%;
    -moz-transform-origin: 50% 100%;
    -ms-transform-origin: 50% 100%;
    -o-transform-origin: 50% 100%;
    transform-origin: 50% 100%;
    -webkit-transform: perspective(300px) rotateX(15deg);
    -moz-transform: perspective(300px) rotateX(15deg);
    -ms-transform: perspective(300px) rotateX(15deg);
    -o-transform: perspective(300px) rotateX(15deg);
    transform: perspective(300px) rotateX(15deg);

to:

    -moz-transform-origin: 50% 100%;
    -ms-transform-origin: 50% 100%;
    -o-transform-origin: 50% 100%;
    -moz-transform: perspective(300px) rotateX(15deg);
    -ms-transform: perspective(300px) rotateX(15deg);
    -o-transform: perspective(300px) rotateX(15deg);

Not ideal, and perhaps one could do some Javascript to check if the browser is NOT Webkit and add back the generic transform styles, but this is good enough for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants