Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Auto updater doesn't work #4641

Closed
MartinX3 opened this issue Nov 4, 2020 · 8 comments
Closed

[BUG] Auto updater doesn't work #4641

MartinX3 opened this issue Nov 4, 2020 · 8 comments
Labels

Comments

@MartinX3
Copy link

MartinX3 commented Nov 4, 2020

Describe the bug

Since a long time I am needed to manual trigger the updater by choosing the newer version by hand in the menu. (Before 9.2.4, maybe it broke at my site with the 9.2.0 update)
It did work in the past a long time ago and I thought it will be patched by a newer update.
That's the reason why I report it now.

To Reproduce

Waiting for the updater mess

Informations

  • LE Version: 9.2.4
  • Hardware Platform: RPi3

Log file

http://ix.io/2CYm

Additional context

I wasn't able to execute the log function in the settings menu.
It stay on "Pasting..." forever.

But logging in via ssh was successful.

LibreElec:~ # pastekodi
error=1 error_msg="Command not registered"
Use 'vcgencmd commands' to get a list of commands
http://ix.io/2CYm

The Raspi3 has internet access.
I can watch IPTV, ping other servers via ssh, and stream stuff.

@chewitt
Copy link
Member

chewitt commented Nov 4, 2020

The auto-update function requires one of the project staff to manually update release information server-side. Only after this step are clients told that a new release is available and the download/update behaviour is triggered. As our current release manager consistently forgets about this step (all the focus is on building/uploading the files) the auto-update function works fine but isn't triggered. This is a long-standing human/process issue not an actual bug.

NB: Current behaviour will likely continue until we rewrite the settings add-on (which needs to be done for Python3) to move the auto-update logic client-side and eliminate humans from the process.

ping @CvH

@MartinX3
Copy link
Author

MartinX3 commented Nov 4, 2020

Thank you very much for your response and I wish you all the best eliminating every human. <3

And yeah, the updater then could look on every boot + every X hours at the github releases on this repo via the api.

@mglae
Copy link
Contributor

mglae commented Nov 5, 2020

Updater is already fixed in #4547.

@CvH
Copy link
Member

CvH commented Nov 9, 2020

The updater was borked and didn't worked properly. After fixing we forgot to bump the package at LE 9.2 branch so the fix was never merged into any release.

@CvH CvH added the LE 9.2 label Nov 20, 2020
@svenfoo
Copy link
Contributor

svenfoo commented Nov 24, 2020

Keeping the update information separate from he availability of the release on github actually seems to be a good idea. It allows you to make a release and then wait a few days before providing it as an automatic update to all users. Only some interested and technically versatile users will manually update during the first days, which gives you a chance to catch bugs before they hit the broad mass of devices out there. With a little logic on the update server you could also implement a phased roll-out of automatic updates. Just something you might want to consider ...

@chewitt
Copy link
Member

chewitt commented Nov 24, 2020

LE has no plans to release files on GitHub as we already use a global list of mirrors and it would technically be an abuse of GitHub TOS, and we already do the two stage release process where files are posted and then later (when someone remembers) the auto-update config is changed. This needs to change at some point to move the logic wholly into the settings add-on so the dependency on forgetful staff and need for an update server to exist (beyond stats collection, it's second purpose) are removed.

@MartinX3
Copy link
Author

Looks like it was #4633 ?

Hopefully we get a 9.2.7 release with this update. :)

@chewitt
Copy link
Member

chewitt commented Mar 8, 2021

I'm closing this ticket out as the issue was resolved in LE 10.0 codebase and there will be no LE 9.2.7 release.

@chewitt chewitt closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants