Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sparse.GCXS silently requires canonical form #13

Closed
uellue opened this issue Jun 26, 2023 · 2 comments · Fixed by #14
Closed

sparse.GCXS silently requires canonical form #13

uellue opened this issue Jun 26, 2023 · 2 comments · Fixed by #14
Labels
bug Something isn't working

Comments

@uellue
Copy link
Member

uellue commented Jun 26, 2023

As a reminder to report upstream: If the indices in a CSR matrix are not sorted, GCXS silently drops parts of the data.

Reproduced in /cachedata/alex/Gd2O3-pelz-diffraction__5-sparse-csr/sparse0.toml and /er-c-data/adhoc/eventdetector/opendirect.ipynb
@uellue uellue added the bug Something isn't working label Jun 26, 2023
@uellue
Copy link
Member Author

uellue commented Jun 26, 2023

...and it also seems to ignore duplicates?

@uellue
Copy link
Member Author

uellue commented Jul 4, 2023

Reported upstream: pydata/sparse#602

Work on fixes in #14

@uellue uellue mentioned this issue Jul 11, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Test non-canonical sparse arrays uellue/sparseconverter
1 participant
@uellue