From e02057790b8033cbac49597c5017272707d28fae Mon Sep 17 00:00:00 2001 From: Fang-Pen Lin Date: Tue, 7 Jan 2025 00:55:46 -0800 Subject: [PATCH] Add todo --- src/storage/spiflash.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/storage/spiflash.rs b/src/storage/spiflash.rs index 47ba956..f0c63bc 100644 --- a/src/storage/spiflash.rs +++ b/src/storage/spiflash.rs @@ -53,6 +53,9 @@ impl SPIFlashStorage { // TODO: handle file system not formatted issue. // looks like esp-idf-svc didn't implement error handling at this moment: // https://github.com/esp-rs/esp-idf-svc/blob/6453bedd5967ebc3bcb7d240492a0d5164e818c2/src/io.rs#L130 + // TODO: the f_mount called with async mode, it means the actual mount will only happen in + // a file operation. Maybe we should leave file sys formatting to the end-user + // instead? as it's a dangerous operation anyway.... self.mounted_fatfs = Some(MountedFatfs::mount(fatfs, mount_path, max_fds)?); Ok(()) }