Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move risk based point estimate out of metrics #129

Open
drewoldag opened this issue Nov 21, 2022 · 1 comment
Open

Move risk based point estimate out of metrics #129

drewoldag opened this issue Nov 21, 2022 · 1 comment
Labels
good first issue Good for newcomers metric new/upgraded metric needed parameterization new/upgraded PDF parameterization need

Comments

@drewoldag
Copy link
Collaborator

It would make sense to port the risk based point estimate from the metrics module to a function on the pdf class itself.

@aimalz aimalz added good first issue Good for newcomers parameterization new/upgraded PDF parameterization need labels Dec 6, 2022
@drewoldag
Copy link
Collaborator Author

This is the wrapper that will process elements of an Ensemble and pass the heavy lifting to...
https://github.com/LSSTDESC/qp/blob/main/src/qp/metrics/metrics.py#L162

... this function which does that actual work.
https://github.com/LSSTDESC/qp/blob/main/src/qp/metrics/array_metrics.py#L101

Because this is a metric that characterizes a single distribution or Ensemble, it makes sense for it to be a function that can be called like .pdf() or .cdf() on a Ensemble or distribution.

@aimalz aimalz added the metric new/upgraded metric needed label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers metric new/upgraded metric needed parameterization new/upgraded PDF parameterization need
Projects
None yet
Development

No branches or pull requests

2 participants