Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Workspace indicator not working properly #1211

Closed
Ashikaga1974 opened this issue Jan 3, 2025 · 3 comments
Closed

[BUG]: Workspace indicator not working properly #1211

Ashikaga1974 opened this issue Jan 3, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@Ashikaga1974
Copy link

Ashikaga1974 commented Jan 3, 2025

Summary

I have 5 workspaces, workspace 1 has the name “Work”, workspace 2 has the name “Mail”. I start Outlook and Teams with one rule:

  “workspaces": [
    {
      “name": ‘Work’,
      “layout": ”UltrawideVerticalStack”
    },
    {
      “name": ‘Mail’,
      “layout": ‘UltrawideVerticalStack’,
      “initial_workspace_rules": [
        {
          “kind": ‘Exe’,
          “id": ”OUTLOOK.EXE”
        },
        {
          “kind": ‘Exe’,
          “id": ”ms-teams.exe”
        }
      ]
    },
    {
      “name": ‘III’,
      “layout": ”UltrawideVerticalStack”
    },
    {
      “name": ‘IV’,
      “layout": ”UltrawideVerticalStack”
    },
    {
      “name": ‘V’,
      “layout": ”Rows”
    }
  ]

If I am on workspace 1, then click on the open Outlook, komorebi switches to Outlook, but the workspace indicator of the Bar stays on workspace 1 and does not switch to workspace 2

Version Information

W10 or Win11 doesn't matter...

komorebic 0.1.32
tag:v0.1.32
commit_hash:4b9d8114
build_time:2025-01-01 19:37:02 +00:00
build_env:rustc 1.83.0 (90b35a623 2024-11-26),stable-x86_64-pc-windows-msvc

Komorebi Configuration

Komorebi.json:

{
  "$schema": "https://raw.githubusercontent.com/LGUG2Z/komorebi/v0.1.31/schema.json",
  "app_specific_configuration_path": "$Env:KOMOREBI_CONFIG_HOME/applications.json",
  "animation": {
    "enabled": false,
    "duration": 200,
    "style": "Linear",
    "fps": 120 
  },
  "border": true,
  "border_width": 3,
  "border_offset": -1,
  "cross_monitor_move_behaviour": "Insert",
  "default_workspace_padding": 5,
  "default_container_padding": 5,
  "mouse_follows_focus": false,
  "monitors": [
    {
      "work_area_offset": {
        "left": 0,
        "top": 45,
        "right": 0,
        "bottom": 40
      },
      "workspaces": [
        {
          "name": "Work",
          "layout": "UltrawideVerticalStack"
        },
        {
          "name": "Mail",
          "layout": "UltrawideVerticalStack",
          "initial_workspace_rules": [
            {
              "kind": "Exe",
              "id": "OUTLOOK.EXE"
            },
            {
              "kind": "Exe",
              "id": "ms-teams.exe"
            }
          ]
        },
        {
          "name": "III",
          "layout": "UltrawideVerticalStack"
        },
        {
          "name": "IV",
          "layout": "UltrawideVerticalStack"
        },
        {
          "name": "V",
          "layout": "Rows"
        }
      ]
    }
  ],
  "resize_delta": 100,
  "theme": {
    "palette": "Base16",
    "name": "GoogleLight",
    "unfocused_border": "Base01",
    "bar_accent": "Base0D"
  },
  "stackbar": {
    "height": 40,
    "mode": "OnStack",
    "tabs": {
      "width": 300
    }
  },
  "transparency": true,
  "transparency_alpha": 240,
  "transparency_ignore_rules": [
    {
      "kind": "Exe",
      "id": "komorebi-bar.exe",
      "matching_strategy": "Equals"
    }
  ],
  "window_hiding_behaviour": "Cloak",
  "manage_rules": [
    {
      "kind": "Exe",
      "id": "RemoteDesktopManager.exe",
      "matching_strategy": "Contains"
    }
  ]
}

Bar.json:
{

  "_comment": "JSON File for KOMOREBI-BAR",

  "$schema": "https://raw.githubusercontent.com/LGUG2Z/komorebi/v0.1.31/schema.bar.json",

  "center_widgets": [
    {
      "Date": {
        "enable": true,
        "format": "DateMonthYear"
      }
    },
    {
      "Time": {
        "enable": true,
        "format": "TwentyFourHour"
      }
    }
  ],

  "font_family": "JetBrains Mono",

  "grouping" :{
    "kind": "Alignment",
    "rounding": 5,
    "style":"Default",
    "transparency_alpha": 255
  },

  "left_widgets": [
    {
      "Komorebi": {
        "workspaces": {
          "enable": true,
          "hide_empty_workspaces": false
        },
        "layout": {
          "enable": true
        },
        "focused_window": {
          "enable": true,
          "show_icon": true
        }
      }
    }
  ],

  "monitor": {
    "index": 0,
    "work_area_offset": {
      "left": 0,
      "top": 40,
      "right": 0,
      "bottom": 40
    }
  },

  "right_widgets": [
    {
      "Media": {
        "enable": true
      }
    },
    {
      "Storage": {
        "enable": false,
        "label_prefix": "Icon"
      }
    },
    {
      "Cpu": {
        "enable": true,
        "data_refresh_interval": 5,
        "label_prefix": "Icon"
      }
    },    
    {
      "Memory": {
        "enable": true,
        "label_prefix": "Icon"
      }
    },
    {
      "Network": {
        "enable": true,
        "show_total_data_transmitted": true,
        "show_network_activity": true,
        "show_default_interface": false
      }
    }
  ],

  "transparency_alpha": 0
}

Hotkey Configuration

default

Output of komorebic check

KOMOREBI_CONFIG_HOME detected: C:\Users\xxxxxxxxx.config\komorebi

Looking for configuration files in C:\Users\xxxxxxxxxxx.config\komorebi

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\xxxxxxxxxxxxxxx.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag

@Ashikaga1974 Ashikaga1974 added the bug Something isn't working label Jan 3, 2025
@LGUG2Z
Copy link
Owner

LGUG2Z commented Jan 4, 2025

then click on the open Outlook

Where are you clicking to trigger the focus change? 👀

@LGUG2Z LGUG2Z closed this as completed in 39c82bd Jan 4, 2025
@LGUG2Z
Copy link
Owner

LGUG2Z commented Jan 4, 2025

Should be fixed in the next nightly tagged release tonight

LGUG2Z added a commit that referenced this issue Jan 5, 2025
If a user triggers the workspace reconciliator by clicking on an app in
the start bar or via alt-tab, a notification should be sent to
subscribers such as komorebi-bar so that the focused workspace can be
updated.

The various komorebi reconciliators and manager modules don't emit
events to subscribers themselves (yet?), so for now we can pass on the
uncloak event.

Maybe we can look into expanding the Notification enum in the future.

fix #1211
@Ashikaga1974
Copy link
Author

Works with Version:

komorebic 0.1.33
branch:master
commit_hash:b5a40a7a
build_time:2025-01-05 03:30:32 +00:00
build_env:rustc 1.83.0 (90b35a623 2024-11-26),stable-x86_64-pc-windows-msvc

Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants