Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Embedded youtube videos can't enter fullscreen #1122

Closed
dinesh-58 opened this issue Nov 16, 2024 · 1 comment
Closed

[BUG]: Embedded youtube videos can't enter fullscreen #1122

dinesh-58 opened this issue Nov 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dinesh-58
Copy link

dinesh-58 commented Nov 16, 2024

Summary

Steps to recreate:

  • Open page with embedded youtube video. Example
  • Play and enter fullscreen. This causes the video to exit fullscreen immediately

Version Information

OS Name: Microsoft Windows 10 Home
OS Version: 10.0.19045 N/A Build 19045

komorebic 0.1.30
tag:v0.1.30
commit_hash:9a3dbccc
build_time:2024-11-03 23:49:52 +00:00
build_env:rustc 1.82.0 (f6e511eec 2024-10-15),stable-x86_64-pc-windows-msvc

Komorebi Configuration

"$schema": "https://raw.githubusercontent.com/LGUG2Z/komorebi/v0.1.30/schema.json",
  "app_specific_configuration_path": "$Env:KOMOREBI_CONFIG_HOME/applications.json",
  "window_hiding_behaviour": "Cloak",
  "cross_monitor_move_behaviour": "Insert",
  "default_workspace_padding": 0,
  "default_container_padding": 0,
  "border_padding": 0,
  "border_offset": 0,
  "border_width": 2,
  "border": true,
  "border_colours": {
    "single": "#fff",
    "stack": "#00a542",
    "monocle": "#ff3399"
  },
  "mouse_follows_focus": false,
  "monitors": [
    {
      "workspaces": [
        {
          "name": "1",
          "layout": "VerticalStack",
          "initial_workspace_rules": [
              {
                  "id": "emacs.exe",
                  "kind": "Exe",
                  "matching_strategy": "Equals"
              }
          ]
        },
        {
          "name": "2",
          "layout": "VerticalStack",
          "initial_workspace_rules": [
              {
                  "id": "firefox.exe",
                  "kind": "Exe",
                  "matching_strategy": "Equals"
              }
          ]
        },
        {
          "name": "3",
          "layout": "VerticalStack"
        },
        {
          "name": "4",
          "layout": "VerticalStack"
        },
        {
          "name": "5",
          "layout": "VerticalStack"
        }
      ]
    }
  ],
  "ignore_rules": [
    {
      "kind": "Exe",
      "id": "Zebar.exe",
      "matching_strategy": "Equals"
    }, 
    {
        "kind": "Title",
        "id": "[Pp]icture.in.[Pp]icture",
        "matching_strategy": "Regex"
    }

  ],
  "stackbar": {
    "height": 20,
    "mode": "OnStack",
    "tabs": {
      "width": 300,
      "focused_text": "#00a542",
      "unfocused_text": "#b3b3b3",
      "background": "#141414"
    }
  }
}

Hotkey Configuration

.shell pwsh

# Reload whkd configuration
# alt + o                 : taskkill /f /im whkd.exe && start /b whkd # if shell is cmd
alt + o                 : taskkill /f /im whkd.exe; Start-Process whkd -WindowStyle hidden # if shell is pwsh / powershell
alt + shift + o         : komorebic reload-configuration

# App shortcuts - these require shell to be pwsh / powershell
# The apps will be focused if open, or launched if not open
alt + b                 : if ($wshell.AppActivate('Firefox') -eq $False) { start firefox }
# alt + b                 : if ($wshell.AppActivate('Chrome') -eq $False) { start chrome }
alt + escape            : start wt

# Focus windows
alt + h                 : komorebic focus left
alt + j                 : komorebic cycle-focus next
alt + k                 : komorebic cycle-focus previous
alt + l                 : komorebic focus right
# alt + shift + oem_4     : komorebic cycle-focus previous # oem_4 is [
# alt + shift + oem_6     : komorebic cycle-focus next # oem_6 is ]

# Move windows
alt + shift + h         : komorebic move left
alt + shift + j         : komorebic move down
alt + shift + k         : komorebic move up
alt + shift + l         : komorebic move right
alt + shift + return    : komorebic promote

# Stack windows
#alt + left              : komorebic stack left
#alt + down              : komorebic stack down
#alt + up                : komorebic stack up
#alt + right             : komorebic stack right
alt + oem_1             : komorebic unstack # oem_1 is ;
alt + oem_4             : komorebic cycle-stack previous # oem_4 is [
alt + oem_6             : komorebic cycle-stack next # oem_6 is ]

# Resize
alt + oem_plus          : komorebic resize-axis horizontal increase
alt + oem_minus         : komorebic resize-axis horizontal decrease
alt + shift + oem_plus  : komorebic resize-axis vertical increase
alt + shift + oem_minus : komorebic resize-axis vertical decrease

# Manipulate windows
alt + shift + f         : komorebic toggle-float
alt + f                 : komorebic toggle-maximize
alt + shift + c         : komorebic close
alt + d                 : komorebic minimize


# Window manager options
alt + shift + r         : komorebic retile
alt + p                 : komorebic toggle-pause

# Layouts
# alt + x                 : komorebic flip-layout horizontal
# alt + y                 : komorebic flip-layout vertical

# Workspaces
alt + 1                 : komorebic focus-workspace 0
alt + 2                 : komorebic focus-workspace 1
alt + 3                 : komorebic focus-workspace 2
alt + 4                 : komorebic focus-workspace 3
alt + 5                 : komorebic focus-workspace 4
alt + w                 : komorebic focus-last-workspace

# Move windows across workspaces
alt + shift + 1         : komorebic send-to-workspace 0
alt + shift + 2         : komorebic send-to-workspace 1
alt + shift + 3         : komorebic send-to-workspace 2
alt + shift + 4         : komorebic send-to-workspace 3
alt + shift + 5         : komorebic send-to-workspace 4

Output of komorebic check

KOMOREBI_CONFIG_HOME detected: C:\Users\sujal.config\komorebi

Looking for configuration files in C:\Users\sujal.config\komorebi

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\sujal.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag

@dinesh-58 dinesh-58 added the bug Something isn't working label Nov 16, 2024
@dinesh-58
Copy link
Author

nvm this got fixed by itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant