Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging reconf_at_edges_server into Navigation #37

Closed
Jailander opened this issue Oct 26, 2020 · 4 comments
Closed

Merging reconf_at_edges_server into Navigation #37

Jailander opened this issue Oct 26, 2020 · 4 comments
Assignees
Labels

Comments

@Jailander
Copy link
Collaborator

The action reconfiguration at edges was a late addition to our navigation pipeline and it was a bit messy, mainly because its a separate service configured by a different file which adds a lot of complexity to the system, additional points of problems and unnecessary delays.

The way to overcome this, is to fully integrate the edge re-configuring into the navigation server (#33 ). The new map format (#35 ) already provides for this in the edge definition where the config field can be used to define parameters that can be reconfigured using the rqt_reconfigure interface.

edges:                              # List of edges departing from the node
  - action: move_action               # Action Name
    node: WayPoint002
    config: &move_action_config_1             # Action Configuration
      inflation_radius: 0.0                   # Action Parameters
      top_vel: 0.55
      recovery_behaviours_config: ''
    action_type: 'move_action_msgs/MoveActionGoal'      # Goal type for the Action
    goal:
      target_pose: $node.pose
@Jailander
Copy link
Collaborator Author

@adambinch do you think of the config field? will we need more parameters? (I was thinking name of reconf server)

@adambinch
Copy link
Collaborator

Edge config is now:

    edges:                        # List of edges departing from the node
    - action: move_action                # Action Name
      edge_id: WayPoint001_WayPoint002
      node: WayPoint002
      config: &move_action_config_1             # Edge Reconfigure
      - namespace: param1_namespace                   # Parameter
        name: param1_name
        value: param1_value
      - namespace: param2_namespace                   # Parameter
        name: param2_name
        value: param2_value

@adambinch
Copy link
Collaborator

adambinch commented Feb 25, 2021

Edge reconfigure for the new map is now implemented in the main navigation script (navigation.py) but not as yet for the execute policy server, which is due to be integrated with navigation.py. Issue #33 needs to be resolved before this issue can be fully resolved.

@adambinch
Copy link
Collaborator

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants