Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model and data objects missing in PM_result after rust run #41

Open
mnneely opened this issue Mar 23, 2024 · 2 comments
Open

Model and data objects missing in PM_result after rust run #41

mnneely opened this issue Mar 23, 2024 · 2 comments

Comments

@mnneely
Copy link

mnneely commented Mar 23, 2024

They aren't being saved, so they aren't being loaded. This will cause all kinds of functions which need to access the data and model in the PM_result to crash. Need to save the PM_data and PM_model$model_list objects after a run.

@mhovd
Copy link
Collaborator

mhovd commented Mar 31, 2024

I made some slight changes to this, allowing the user (or us) to give the PM_fit directly
If you have the time, can you give it a look?

LAPKB/Pmetrics@3151770

@mnneely
Copy link
Author

mnneely commented Apr 1, 2024

Looks fine to me. You saw that I added a cov object to make rust output compatible with the PM_cov functions, but I see you made it a conditional creation. I’m on vacation at the moment with only my iPad, so I don’t have my laptop to look properly at code, but it looks like this is a good error check, since make_Cov depends on final existing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants