Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0.2: autocage generates an error multiple times. #16

Open
karpana opened this issue Aug 15, 2024 · 5 comments
Open

11.0.2: autocage generates an error multiple times. #16

karpana opened this issue Aug 15, 2024 · 5 comments

Comments

@karpana
Copy link

karpana commented Aug 15, 2024

blizz dropped a surprise internal api change on us yesterday with the release of 11.0.2

Autocage now generates this error when the game is started up

7x AutoCage/AutoCage.lua:172: attempt to call global 'IsAddOnLoaded' (a nil value)
[string "@AutoCage/AutoCage.lua"]:172: in function `AutoCage_JournalHook'
[string "@AutoCage/AutoCage.lua"]:244: in function <AutoCage/AutoCage.lua:232>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@Blizzard_UIParent/Mainline/UIParent.lua"]:422: in function `UIParentLoadAddOn'
[string "@Rarity/Core/Collections.lua"]:63: in function `ScanToys'
[string "@Rarity/Core/Collections.lua"]:282: in function `ScanExistingItems'
[string "@Rarity/Core.lua"]:178: in function `DoEnable'
[string "@Rarity/Core.lua"]:150: in function <Rarity/Core.lua:149>
[string "=[C]"]: ?
[string "@AnnounceRare/Libraries/Ace3/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...nceRare/Libraries/Ace3/AceAddon-3.0/AceAddon-3.0.lua:61>
...
[string "@Blizzard_UIParent/Mainline/UIParent.lua"]:627: in function `MajorFactions_LoadUI'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:103: in function `SetUpMajorFactionList'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:96: in function `RefreshMajorFactionList'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:91: in function `RefreshOverlay'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:83: in function <...sionLandingPage/Blizzard_DragonflightLandingPage.lua:79>
[string "=[C]"]: ?
[string "=[C]"]: in function `CreateFrame'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:49: in function `CreateOverlay'
[string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:78: in function `RefreshExpansionOverlay'
[string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:37: in function <...pansionLandingPage/Blizzard_ExpansionLandingPage.lua:35>

Locals:
(*temporary) = nil
(*temporary) = "Rematch"
(*temporary) = "attempt to call global 'IsAddOnLoaded' (a nil value)"
acHasHooked = false
@karpana
Copy link
Author

karpana commented Aug 15, 2024

following the guidance of other addon developers that are scrambling to catch up to these surprise changes, adding the following line of code right before the offending lines of code seems to resolve the issue

    local IsAddOnLoaded = C_AddOns.IsAddOnLoaded or IsAddOnLoaded

the line this needs to be added at are line 172 and lines 250

@I-AM-T3X
Copy link
Contributor

following the guidance of other addon developers that are scrambling to catch up to these surprise changes, adding the following line of code right before the offending lines of code seems to resolve the issue

    local IsAddOnLoaded = C_AddOns.IsAddOnLoaded or IsAddOnLoaded

the line this needs to be added at are line 172 and lines 250

I've already resolved this issue in my pull request. Now, I'm just waiting for @Kruithne to review and merge my changes into the main branch.

@karpana
Copy link
Author

karpana commented Aug 15, 2024

Hadn't seen your pull request @I-AM-T3X . Glad to see we have a healthy community of developer-types looking at this from different perspectives. Looking forward to a formal fix. Cheers.
Karp.

@karpana
Copy link
Author

karpana commented Aug 15, 2024

Also @I-AM-T3X , I just looked over your pull pull request, and I see you caught one other reference to isAddOnLoaded that my "brute force" fix missed. Kudos.

@I-AM-T3X
Copy link
Contributor

Thanks, @karpana! It’s been a bit of a scramble with the recent API changes, but I’m glad we’re all working together to get things sorted quickly. I’m actually pretty new to Lua—I started learning because there are a few addons I use that aren’t being updated anymore, so I’ve been picking it up to keep them working for personal use. I really appreciate your thorough review and the collaborative spirit. Hopefully, we’ll have everything running smoothly again once the pull request is merged. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants