Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koverHtmlReport task fails when macrobenchmark project is configured #508

Closed
smozhaykin opened this issue Nov 17, 2023 · 2 comments
Closed
Assignees
Labels
Bug Bug issue type S: waiting for clarification Status: additional information required to proceed

Comments

@smozhaykin
Copy link

Describe the bug
koverHtmlReport task fails when macrobenchmark project is configured. Sample is available here (forked from https://github.com/android/performance-samples): smozhaykin/performance-samples@def292e

Errors

gradlew clean koverHtmlReport
> Task :macrobenchmark:koverHtmlReport FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Some problems were found with the configuration of task ':macrobenchmark:koverHtmlReport' (type 'KoverHtmlTask').
  - In plugin 'org.jetbrains.kotlinx.kover' type 'kotlinx.kover.gradle.plugin.tasks.reports.KoverHtmlTask' property 'filters' doesn't have a configured value.

    Reason: This property isn't marked as optional and no value has been configured.

    Possible solutions:
      1. Assign a value to 'filters'.
      2. Mark property 'filters' as optional.

    Please refer to https://docs.gradle.org/8.1.1/userguide/validation_problems.html#value_not_set for more details about this problem.
  - In plugin 'org.jetbrains.kotlinx.kover' type 'kotlinx.kover.gradle.plugin.tasks.reports.KoverHtmlTask' property 'reportDir' doesn't have a configured value.

    Reason: This property isn't marked as optional and no value has been configured.

    Possible solutions:
      1. Assign a value to 'reportDir'.
      2. Mark property 'reportDir' as optional.

    Please refer to https://docs.gradle.org/8.1.1/userguide/validation_problems.html#value_not_set for more details about this problem.
  - In plugin 'org.jetbrains.kotlinx.kover' type 'kotlinx.kover.gradle.plugin.tasks.reports.KoverHtmlTask' property 'title' doesn't have a configured value.

    Reason: This property isn't marked as optional and no value has been configured.

    Possible solutions:
      1. Assign a value to 'title'.
      2. Mark property 'title' as optional.

    Please refer to https://docs.gradle.org/8.1.1/userguide/validation_problems.html#value_not_set for more details about this problem.

Expected behavior
Kover plugin should gracefully handle projects with macrobenchmark.

Reproducer
smozhaykin/performance-samples@def292e

Environment

  • Kover Gradle Plugin version: 0.7.4
  • Gradle version: 8.1.1
  • Kotlin project type: Kotlin/Android
@smozhaykin smozhaykin added Bug Bug issue type S: untriaged Status: issue reported but unprocessed labels Nov 17, 2023
@shanshin
Copy link
Collaborator

Hi,
to generate merged report you just need to call the task only for the root project (where subprojects { is specified) - thus Gradle commands will be gradlew clean :koverHtmlReport (with colon) instead of gradlew clean koverHtmlReport.

However, unfortunately, tests on devices are not supported now, so the report will display coverage 0 for all classes.
See also #96

@shanshin shanshin added S: waiting for clarification Status: additional information required to proceed and removed S: untriaged Status: issue reported but unprocessed labels Nov 20, 2023
@shanshin
Copy link
Collaborator

Closed as stale.

Feel free to open new issue if you have any additional questions.

@shanshin shanshin closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug issue type S: waiting for clarification Status: additional information required to proceed
Projects
None yet
Development

No branches or pull requests

2 participants