You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue:
Repairing a run output and clicking Accept repair (5 Stars) does not include the repaired run in the fine-tune datasplits.
Expected:
Accepting a repair should turn the run into a 5 stars and as such the repaired output should be included in newly created fine-tune datasplits that filter for `High Rating (4+ stars).
Accept the repaired output by clicking Accept Repair (5 stars)
In Fine Tune:
a. Create a fine-tune
b. Pick Download: OpenAI chat format with tool calls (JSONL) (or any other)
c. New dataset
d. In Dataset Filter, select High Rating (4+ stars)
e. In Dataset Splits, select Entire Dataset -- 100
f. Create Dataset
The file does not include the repaired run.
The filtering logic for High Rating seems to be done here:
Adding or task_run.repaired_output is not None in the bool check would only fix the filtering, but not the downstream code uses the output rather than the repaired_output - so downstream logic like creating datasplits would use the original output rather than the one coming out of the repair.
What are your plans for how repaired_output should be used?
If repaired_output is used for prompt generation but not included in fine tuning data, maybe then renaming the Accept Repair (5 stars) button could reduce confusion as the 5 stars mention suggests the repair would cause the run to behave as if it were rated 5 stars.
The text was updated successfully, but these errors were encountered:
leonardmq
changed the title
Repaired runs not included in dataset
Repaired runs not included in datasplit
Jan 10, 2025
leonardmq
changed the title
Repaired runs not included in datasplit
Repaired run output not included in datasplit
Jan 10, 2025
Issue:
Repairing a run output and clicking
Accept repair (5 Stars)
does not include the repaired run in the fine-tune datasplits.Expected:
Accepting a repair should turn the run into a 5 stars and as such the repaired output should be included in newly created fine-tune datasplits that filter for `High Rating (4+ stars).
Version:
main
at 1f4c281f207f208ea6d956c8e7c23ce6d7aab251Steps to reproduce:
3 Stars
on theOverall Rating
Accept Repair (5 stars)
Fine Tune
:a. Create a fine-tune
b. Pick
Download: OpenAI chat format with tool calls (JSONL)
(or any other)c. New dataset
d. In
Dataset Filter
, selectHigh Rating (4+ stars)
e. In
Dataset Splits
, selectEntire Dataset -- 100
f. Create Dataset
The file does not include the repaired run.
The filtering logic for High Rating seems to be done here:
Kiln/libs/core/kiln_ai/datamodel/__init__.py
Line 601 in 1f4c281
Adding
or task_run.repaired_output is not None
in the bool check would only fix the filtering, but not the downstream code uses theoutput
rather than therepaired_output
- so downstream logic like creating datasplits would use the original output rather than the one coming out of the repair.What are your plans for how
repaired_output
should be used?If
repaired_output
is used for prompt generation but not included in fine tuning data, maybe then renaming theAccept Repair (5 stars)
button could reduce confusion as the5 stars
mention suggests the repair would cause the run to behave as if it were rated 5 stars.The text was updated successfully, but these errors were encountered: