Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour when loading file is different to behaviour when re-running file #41

Open
hybridherbst opened this issue Jan 9, 2025 · 4 comments

Comments

@hybridherbst
Copy link
Contributor

hybridherbst commented Jan 9, 2025

This file tests all math nodes for float types:
20250109-MathTests.zip

! This issue requires the fixes from our fork at the moment – registering missing nodes etc.

However, when initially loading it, it looks like this:
image

When pressing Play again, it looks like this:
image

I'm unsure what's wrong here. I believe the data is correct but maybe there's something else going on.

@boguscoder
Copy link

@hybridherbst quick question, unrelated to your observation but related to your file:
are inputs to ADBE/output_console_node spec - compliant? Id imagine it need to be
value: ["message"]
instead of
value : "message"
They fail in my parser hence the question

@boguscoder
Copy link

boguscoder commented Jan 9, 2025

Actually I just realized that no string value types are spec-compliant, but are often needed to test anything..

@hybridherbst
Copy link
Contributor Author

Yeah, good question, and I believe it depends on the spec for ADBE/output_console_node, which is basically an extension – we're just using that because this viewer here supports it. Where strings are used in the rest of the spec is as configurations, and configuration strings are never arrays, so I'm honestly not sure.

Unfortunately I don't know how to get Aero (where I believe the extension is coming from) to actually export a KHR_interactivity file...

@lexaknyazev for string types used in extensions, like the ADBE/output_console_node, do you have a recommendation? Should the value be stored as value: [ "some message"] or value: "some message"?

@boguscoder
Copy link

Its one of those things I asked to clarify in spec, I think values are never not-arrayed whether custom types or not (your test file also have few booleans that need to be put into array, I think)

Speaking of custom types, spec only mentions them for variables not for inputs, so its unclear if its even allowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants