Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Overlap with KHR_interactivity support in Babylon.js #28

Open
hybridherbst opened this issue Nov 13, 2024 · 2 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@hybridherbst
Copy link
Contributor

Babylon.js is also moving towards supporting KHR_interactivity and the related nodes* extensions.
https://forum.babylonjs.com/t/gltf-interactivity-specs/51770/7?u=herbst

This introduces overlap with the implementation here – when updating Babylon in this repository to v7, there are two conflicting KHR_interactivity plugins.

Opening this issue to understand what the plan there is. One option would be if this repository consumes the Babylon implementation and adds graph authoring on top.

cc @mattmacf98

@mattmacf98
Copy link
Contributor

The Babylon extension registry is a last write wins, so as long as you do something like this

GLTFLoader.UnregisterExtension(KHR_INTERACTIVITY_EXTENSION_NAME);
GLTFLoader.RegisterExtension(KHR_INTERACTIVITY_EXTENSION_NAME, (loader) => {
   return new KHR_interactivity(loader);
});

you can essentially ignore the overlap conflict and use the engine in this repo.

In the long term – once the spec and Babylon's implementation are solidified – then I would just use Babylon as the engine for the Babylon component piece and move this engine to only support the logs viewer (and maybe port it to another js based viewer like Three).

In general, this version of the engine – by not being a public library– is able to be more experimental and faster moving, allowing for quicker spec feedback and testing than using Babylon core.

@hybridherbst
Copy link
Contributor Author

Sounds good to me! So we just have to be somewhat wary of doing too many changes to the KHR_interactivity engine here because they may already be implemented in Babylon itself. One such example is the KHR_node_visibility extension which I partially copied from the existing Babylon v7 implementation.

@mattmacf98 mattmacf98 added the documentation Improvements or additions to documentation label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants