Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug:variable/get does not connect to pointer/set. #24

Closed
Hackn0214 opened this issue Sep 15, 2024 · 3 comments
Closed

Bug:variable/get does not connect to pointer/set. #24

Hackn0214 opened this issue Sep 15, 2024 · 3 comments

Comments

@Hackn0214
Copy link

Uploade a glb file with the out-socket of variable/get node is connected to the variable of pointer/set node,
the nodes were loaded, but the connection between them was broken.
MyTest.glb.zip
gltftest

@mattmacf98
Copy link
Contributor

Screen.Recording.2024-09-19.at.8.51.59.AM.mov

There was an issue with the dropdown not picking up the selected config from the graph (I just fixed that see video)

I also saw in your variable get node looks like this

{"configuration":[{"id":"variable","type":1,"value":0}],"type":"variable/get"}

but the spec says single valued items should be singleton arrays https://github.com/KhronosGroup/glTF/blob/interactivity/extensions/2.0/Khronos/KHR_interactivity/Specification.adoc#:~:text=variable%22%2C-,%22value%22%3A%20%5B0%5D,-%7D%0A%20%20%20%20%5D%2C%0A%20%20%20%20%22values%22

so it should be

{"configuration":[{"id":"variable","type":1,"value":[0]}],"type":"variable/get"}

@Hackn0214
Copy link
Author

Thank you for the support with the Variable ID issue.
I also appreciate you pointing out the issues on my side.
If possible, could you change the name of the value input socket for each node from "val" to "value" to match the spec?

@mattmacf98
Copy link
Contributor

mattmacf98 commented Nov 13, 2024

This specific socket naming instance (pointer/set) is fixed now thanks to @hybridherbst! I plan to fix the rest of the names later as part of #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants