Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: web version contain plus sign #12

Closed
KeidsID opened this issue Jan 14, 2025 · 3 comments
Closed

bug: web version contain plus sign #12

KeidsID opened this issue Jan 14, 2025 · 3 comments
Assignees
@KeidsID
Labels
bug Something isn't working severity-3 Trivial level severity. Doesn't directly impact the project's functionality.

Comments

@KeidsID
Copy link
Owner

KeidsID commented Jan 14, 2025

Severity Level

severity-3 (Trivial)

Description

The web version of the app should not contain a plus sign. The plus sign is used for the mobile version to define a build number for the mobile app.

  • OS: Linux Ubuntu
  • Browser: Brave

Steps To Reproduce

  1. Visit https://keidsid.github.io/dicoding_story_fl.
  2. Sign in to the app.
  3. Open profile page.
  4. Open About Dicoding Story.

Expected Results

Web version will not have plus sign

Actual Results

Web vesion contain plus sign

Additional Screenshots/Videos

Screencast.from.2025-01-14.23-44-15.webm

Used OS (Operating System)

Other (mention in the description)

Used Browser (For Web)

Other (mention in the description)
@KeidsID KeidsID added the bug Something isn't working label Jan 14, 2025
@KeidsID KeidsID self-assigned this Jan 14, 2025
@github-actions github-actions bot added the severity-3 Trivial level severity. Doesn't directly impact the project's functionality. label Jan 14, 2025
@KeidsID
Copy link
Owner Author

KeidsID commented Jan 15, 2025

The CD workflow did'nt include build number, so it read as empty string. We will had a build-number.json to store the build number for each new releases.

@KeidsID
Copy link
Owner Author

KeidsID commented Jan 15, 2025

Or maybe implement this action: https://github.com/onyxmueller/build-tag-number

@KeidsID KeidsID mentioned this issue Jan 15, 2025
Merged
@KeidsID
Copy link
Owner Author

KeidsID commented Jan 15, 2025

Omaga

image

@KeidsID KeidsID closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KeidsID KeidsID

Labels
bug Something isn't working severity-3 Trivial level severity. Doesn't directly impact the project's functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KeidsID