Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Symfony EventDispatcher's support (with EventSubscriberInterface) #92

Closed
hranicka opened this issue Mar 8, 2016 · 3 comments
Closed

Comments

@hranicka
Copy link
Contributor

hranicka commented Mar 8, 2016

Maybe this refs to #89

Currently, only Doctrine Events are fully supported.

They're supported Symfony Events too, but only partially. Event dispatching only.

My problem:

I want to use Symfony Console + Monolog + Symfony Monolog Bridge.
It's realized via this subscriber.

But I cannot register this subscriber (eg. with tags in config). It's not a Doctrine EventSubscriber.

I've made another extension of Kdyby/Events extension:
https://github.com/etten/symfony-events


Should I create a PR to this repo for full built-in support of Symfony Events?

I think a lot of changes will be needed - the Symfony EventSubscriber requires static method and carries information about event name, handler method and priority.

@enumag
Copy link
Member

enumag commented Mar 8, 2016

@fprochazka
Copy link
Member

I'm gonna have to think about this more, but I'm not sure full support of symfony/event-dispatcher is a good way. See #97

@fprochazka
Copy link
Member

I've decided - I wanna drastically simplify this package, so adding full support for symfony dispatcher is not doable, sorrry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants