Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multired.py] Bug in "compute_JSD_matrix" #4

Open
Sci-Robot opened this issue Dec 20, 2019 · 0 comments
Open

[multired.py] Bug in "compute_JSD_matrix" #4

Sci-Robot opened this issue Dec 20, 2019 · 0 comments

Comments

@Sci-Robot
Copy link

Hi @KatolaZ,

Firstly, thank you so much for releasing the source code of your excellent work. It's really useful and enlightening.

Describe the bug
While useing these scripts on my data, I got Jensen–Shannon distance bigger than 1, which woundn't be possible. So I went through the paper and code. Then I found the script multired.py line 283 to 286 inconsistent with the definition within subsection Jensen–Shannon distance between graphs, Structural reducibility of multilayer networks . I guess the comment line 281 and line 282 were the original code.

Also, the Von Neumann entropy is calculated using log base 2 in the papre, then the script multired.py line 163 uses base e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant