Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array<> detection is broken #1

Open
KaptainMicila opened this issue Nov 1, 2020 · 2 comments
Open

Array<> detection is broken #1

KaptainMicila opened this issue Nov 1, 2020 · 2 comments
Labels
Duck Taped Duck taped solution. The problem is fixed, but a better solution is welcome. enhancement New feature or request help wanted Extra attention is needed No Kap The Kaptain tried to fix the problem but didn't manage to.

Comments

@KaptainMicila
Copy link
Owner

Array<> breaks everything
Array<type> is broken and requires Array<type > to fix.

The correct syntax would be:
Array<type> normally
Array<class<type> >, to avoid colliding with the >> operator.
@KaptainMicila KaptainMicila added the help wanted Extra attention is needed label Nov 1, 2020
@KaptainMicila KaptainMicila added this to the 1.0 milestone Nov 1, 2020
@KaptainMicila KaptainMicila self-assigned this Nov 1, 2020
@KaptainMicila
Copy link
Owner Author

I did some editing and now the situation is reversed:
Array<> still breaks everything
Array<type> is not broken anymore
Array<class<type>> is detected as correct, and that's not good.

@KaptainMicila KaptainMicila added the wontfix This will not be worked on label Nov 1, 2020
@KaptainMicila
Copy link
Owner Author

I decided to leave this as it is because:
Array<> is not valid anyway (thanks phantombeta for the tip), but it still breaks everything.
Array<type> has been resolved, and that's the best thing right now.
whoever is developing in ZScript has to know that Array<Class<Type>> is not valid anyway, so I'm happy with these results, for now.

If some regex god manages to fix the problem with some regex miracle I will be even happier than I am now.

@KaptainMicila KaptainMicila removed the wontfix This will not be worked on label Nov 1, 2020
@KaptainMicila KaptainMicila added Duck Taped Duck taped solution. The problem is fixed, but a better solution is welcome. No Kap The Kaptain tried to fix the problem but didn't manage to. labels Nov 1, 2020
@KaptainMicila KaptainMicila removed this from the 1.0 milestone Nov 10, 2020
@KaptainMicila KaptainMicila added the enhancement New feature or request label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Duck Taped Duck taped solution. The problem is fixed, but a better solution is welcome. enhancement New feature or request help wanted Extra attention is needed No Kap The Kaptain tried to fix the problem but didn't manage to.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KaptainMicila