Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between --schwab-award and --schwab_equity_award_json? #570

Open
moguzozcan opened this issue Nov 3, 2024 · 3 comments
Open

Comments

@moguzozcan
Copy link

I'm trying to understand what's the difference between these two? Are they basically the same thing in different formats (csv vs json) so one of them are enough?

@ikoz
Copy link

ikoz commented Nov 19, 2024

same question. The json parser doesn't support 'lapse' events too, which are present in the json.

@vmartinv
Copy link
Collaborator

I believe historically there was no official way to export this data from Schwab, so the json method was the only way.
Later on Schwab introduced exporting these transactions to csv, and the parser for that was added.
I think everyone should use the csv, we can keep the json one for backwards compatibility maybe.

@m01
Copy link
Contributor

m01 commented Nov 29, 2024

According to #277, which introduced --schwab_equity_award_json, the different account types have different data formats.

Now you can these days export .csv files out of equity awards as well (in addition to JSON and XML), but the format doesn't seem to match the normal account's .csv export format (based on https://github.com/KapJI/capital-gains-calculator/blob/main/tests/test_data/schwab_transactions.csv); the equity awards .csv files have transactions spread across multiple lines in the CSV etc, which looks brittle (and no, the number of lines a transaction is spread across is not constant, either, but yes, you could probably use a finite state machine to parse it):

Date,	Action,	Symbol,	Description,	Quantity,	FeesAndCommissions,	DisbursementElection,	Amount,	Type,	Shares,	SalePrice,	SubscriptionDate,	SubscriptionFairMarketValue,	PurchaseDate,	PurchasePrice,	PurchaseFairMarketValue,	DispositionType,	GrantId,	VestDate,	VestFairMarketValue,	GrossProceeds,	AwardDate,	AwardId,
2/1/2020,Sale,ABCD,Share sale,10,$0.50,...
(empty first few columns),then details over which shares came from award A
(empty first few columns),then details over which shares came from award B
...
1/1/2020,Deposit,ABCD,RS,5,lots of empty columns (no $ numbers)
lots of empty columns,then vesting details (incl. $VestFairMarketValue)
...

Personally I think the JSON is a better format to parse for equity awards accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants