Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReplaceCut independent from the Cut class #36

Open
stwunsch opened this issue Apr 1, 2020 · 2 comments
Open

Make ReplaceCut independent from the Cut class #36

stwunsch opened this issue Apr 1, 2020 · 2 comments
Assignees

Comments

@stwunsch
Copy link
Contributor

stwunsch commented Apr 1, 2020

Why do we need as input of the ReplaceCut class a Cut object? Wouldn't a tuple like (name, new_cut) be enough? That would be in line with the selection class.

@maxgalli
Copy link
Collaborator

maxgalli commented Apr 1, 2020

Mmm idk honestly, I thought about implementing the double possibility (either a Cut object or a tuple like you said). I wouldn't remove the possibility to pass a Cut object for the simple reason that intuitively, personally, I would be very confused if a class called ReplaceCut doesn't allow to pass a Cut object as an argument. I would be in favor of implementing both (i.e. you can instantiate a variation ReplaceCut either by passing a Cut object or a tuple (new_name, new_expression).

@stwunsch
Copy link
Contributor Author

stwunsch commented Apr 1, 2020

the question is whether Cut is a user facing object. so far, it is not, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants