Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearchitect Flash Chord #83

Open
KCarlile opened this issue Jun 1, 2022 · 0 comments
Open

Rearchitect Flash Chord #83

KCarlile opened this issue Jun 1, 2022 · 0 comments
Labels
core Backend functionality enhancement New feature or request tech debt Code refactor or cleanup
Milestone
Release 2.0

Comments

@KCarlile
Copy link
Owner

KCarlile commented Jun 1, 2022 •
edited
Loading

Background

Rearchitect Flash Chord for improved readability, flow, encapsulation, testing, etc.

Acceptance Criteria

  • PHP and JS code is OOP where possible/logical
  • Configuration is passed into chord generation (i.e. flip the config paradigm from "what options are enabled" to "these are the options enabled")
  • Support JS testing framework
    • Testing framework for PHP shouldn't be necessary for the small amount being used
  • [Optional] Build a code flow diagram an include it in the repo for new contributors

Approach

Notes

This is going to be a big PR or multiple PRs as this is the primary purpose for v2.0.

Notes from #24:

  • Make the metronome.js file fully encapsulated so it could be reused
  • Separate UI setup and event handling from Flash Chord business logic
@KCarlile KCarlile added the enhancement New feature or request label Jun 1, 2022
@KCarlile KCarlile added this to the Release 2.0 milestone Jun 1, 2022
@KCarlile KCarlile moved this to Ready in FlashChord 2.0 Jun 1, 2022
This was referenced Jun 1, 2022
Closed
Open
@KCarlile KCarlile moved this from Ready to In Progress in FlashChord 2.0 Jun 2, 2022
@KCarlile KCarlile added tech debt Code refactor or cleanup core Backend functionality labels Jun 2, 2022
@KCarlile KCarlile mentioned this issue Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Backend functionality enhancement New feature or request tech debt Code refactor or cleanup
Projects
FlashChord 2.0
Status: In Progress
Milestone
Release 2.0
Development

When branches are created from issues, their pull requests are automatically linked.

83-rearchitect-flash-chord KCarlile/flashchord
1 participant
@KCarlile