Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #203

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Fix CI #203

merged 2 commits into from
Nov 23, 2022

Conversation

maleadt
Copy link
Collaborator

@maleadt maleadt commented Nov 23, 2022

As far as I can see, there seems to be an issue with the GitHub API. Even though the GitHub.jl top commit most definitely has some GitHub Actions-generated statuses attached to it, the API returns nothng:

❯ gh api /repos/JuliaWeb/GitHub.jl/commits/master/statuses
[]

❯ gh api /repos/JuliaLang/julia/commits/master/statuses
[
  {
    "url": "https://api.github.com/repos/JuliaLang/julia/statuses/3200219b1f7e2681ece9e4b99bda48586fab8a93",
...

i.e. not an issue with GitHub.jl, as this is the officla gh binary.

As the API does seem to work fine with the Julia repo, I've temporarily switched those tests over to using a commit from there.

@maleadt
Copy link
Collaborator Author

maleadt commented Nov 23, 2022

cc @logankilpatrick @quinnj for review

@KristofferC KristofferC merged commit a9983e9 into JuliaWeb:master Nov 23, 2022
@maleadt maleadt deleted the status branch November 24, 2022 07:19
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.87%. Comparing base (6271289) to head (b8f78c9).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   56.19%   55.87%   -0.32%     
==========================================
  Files          35       36       +1     
  Lines         840      843       +3     
==========================================
- Hits          472      471       -1     
- Misses        368      372       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants