Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a translation layer between TaijaData.jl and CounterfactualExplanations.jl #11

Open
3 tasks
kmariuszk opened this issue Nov 22, 2023 · 3 comments
Open
3 tasks

Comments

@kmariuszk
Copy link
Collaborator

CounterfactualExplanations

  • Add a translation layer which transfers (X, y) tuple into CounterfactualData object (maybe use extensions?)
  • Test it
  • Document it

Problems:

  • How to not lose additional information (e.g., CounterfactualExplanations.CounterfactualData(X, y; domain=(-1.0, 1.0) domain information)?
    • Either add recalculate it in the translation layer or return more data (i.e., X, y, domain)
@kmariuszk
Copy link
Collaborator Author

kmariuszk commented Nov 22, 2023

@pat-alt I noticed there was only few functions that actually pre-process the data additionally to loading it (e.g., specifying the domain of the dataset or specifying the standardization - these are the parts I left commented-out in the #9) and I question if we actually need this extension layer. Do you think it's necessary?

@pat-alt
Copy link
Member

pat-alt commented Jan 3, 2024

@kmariuszk coming back to this now and realizing I missed this comment. I still think we need a translation layer, but unsure whether to place it here or in CE.jl. Let's discuss during our next call.

@pat-alt
Copy link
Member

pat-alt commented Jan 3, 2024

So from what I can tell, a translation layer would be needed to ensure that:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants