Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all maketerm arguments should be mandatory #33

Closed
nsajko opened this issue May 26, 2024 · 2 comments · Fixed by #35
Closed

all maketerm arguments should be mandatory #33

nsajko opened this issue May 26, 2024 · 2 comments · Fixed by #35

Comments

@nsajko
Copy link
Contributor

nsajko commented May 26, 2024 •
edited
Loading

Having two optional arguments means each source code method gets triplicated by the compiler.

Given that this package is supposed to be low-level, making the arguments mandatory should be OK.
This was referenced May 26, 2024
Merged
Merged
@0x0f0f0f
Copy link
Member

Agree @shashi

@shashi
Copy link
Member

shashi commented May 28, 2024

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make all maketerm arguments mandatory
3 participants
@shashi @nsajko @0x0f0f0f