Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooks distance #414

Closed
ericqu opened this issue Mar 24, 2021 · 2 comments
Closed

Cooks distance #414

ericqu opened this issue Mar 24, 2021 · 2 comments

Comments

@ericqu
Copy link
Contributor

ericqu commented Mar 24, 2021

I would like to use Cook's distance.
And I noted that there is already a PR for this here: #368 .
Is it because there is no test for the function that the PR is stuck?
Should I write a/some tests to unstuck the PR? If so, is there some guideline on how to do so ?

@ararslan
Copy link
Member

Hi @ericqu, thanks for your willingness to contribute! If you'd like to add tests, you could look at the existing tests for this package in the test directory and mimic the style of how things are tested. You'd just want to make sure that the values computed from the function in Julia are approximately equal to those computed from another reputable source, e.g. R. If you come up with some tests, you can leave them in a comment in #368 and a maintainer can apply them, or you can make a PR that includes the changes from #368.

@ericqu ericqu closed this as completed Mar 25, 2021
@ericqu
Copy link
Contributor Author

ericqu commented Mar 26, 2021

Hi @ararslan, I thought that it would be a learning opportunity to make PR and test and I thought of doing a PR myself.
Unfortunately, I run into some troubles (see PR #415 ) not so much about the function itself but how the function integrates within GLM and StatsModels which I did not anticipate. I would be grateful if you could have a quick look into it and give me some pointer to progress further and eventually close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants