Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance_profile() doesn't passe kwargs to BenchmarkProfiles.performance_profiles() #143

Open
d-monnet opened this issue Oct 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@d-monnet
Copy link
Contributor

There is no option to pass BenchmarkProfiles.performance_profiles() keyword arguments such as logscale to SolverBenchmark.performance_profiles.
As such it is not possible to desactivate the log scale (among other things) with SolverBenchmark.performance_profiles.
I'm not sure what the workaround would be since the kargs are sent to plot.

@d-monnet d-monnet added the enhancement New feature or request label Oct 13, 2023
@d-monnet d-monnet changed the title performance_profile() doesn't passes kwargs to BenchmarkProfiles.performance_profiles() performance_profile() doesn't passe kwargs to BenchmarkProfiles.performance_profiles() Oct 13, 2023
@dpo
Copy link
Member

dpo commented Dec 30, 2024

A possible solution would be for SolverBenchmark.performance_profiles() to take two Dicts of kwargs instead of one set of kwargs: one that will be passed to BenchmarkProfiles.performance_profiles() and one that will be passed to plot().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants