Major refactor of JSOSuite to use traits and remove most dependencies #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsiqueira
force-pushed
the
clean-up
branch
2 times, most recently
from
25cdf39 to
56da2a1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
===========================================
- Coverage 79.75% 32.25% -47.50%
===========================================
Files 10 15 +5
Lines 242 341 +99
===========================================
- Hits 193 110 -83
- Misses 49 231 +182 ☔ View full report in Codecov by Sentry. |
abelsiqueira
force-pushed
the
clean-up
branch
from
56da2a1 to
f1354e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor to use traits instead of a dataframe and removing extra dependencies.
One of the objectives is to allow dispatching on the Solver, so we can have some type stability. We still won't have the most basic
minimizecall being type stable, since it will use a keyword-basedselect_optimizerto choose an optimizer.@dpo @tmigot Any thoughts on this before I start making larger changes?