PlutoDependencyExplorer not understanding importing local modules

[MasonProtter]

Here's an MWE:

using PlutoDependencyExplorer
const PDE = PlutoDependencyExplorer;
struct SimpleCell <: PDE.AbstractCell
    code
end

julia> let notebook = SimpleCell.(["mod = expr", "using .mod"])
               empty_topology = PDE.NotebookTopology{SimpleCell}();
               topology = PDE.updated_topology(
                  empty_topology,
                  notebook, notebook;
                  get_code_str = c -> c.code,
                  get_code_expr = c -> Meta.parse(c.code))
               order = PDE.topological_order(topology);
               order.runnable
       end
SimpleCell[]

Ideally this should return

2-element Vector{SimpleCell}:
 SimpleCell("mod = expr")
 SimpleCell("using .mod")

This is manifesting in errors in Pluto when I try to import a locally defined module.

[fonsp]

Thanks! Is this also an issue in Pluto?

[fonsp]

julia> order.errable
Dict{SimpleCell, PlutoDependencyExplorer.ReactivityError} with 2 entries:
  SimpleCell("using .mod") => MultipleDefinitionsError(Set([:mod]))
  SimpleCell("mod = expr") => MultipleDefinitionsError(Set([:mod]))

[MasonProtter]

Ah right, sorry I should have given the example without the name clashes:

julia> let notebook = SimpleCell.(["mod = expr", "using .mod: x"])
               empty_topology = PDE.NotebookTopology{SimpleCell}();
               topology = PDE.updated_topology(
                  empty_topology,
                  notebook, notebook;
                  get_code_str = c -> c.code,
                  get_code_expr = c -> Meta.parse(c.code))
               order = PDE.topological_order(topology);
               order.runnable
       end
2-element Vector{SimpleCell}:
 SimpleCell("using .mod: x")
 SimpleCell("mod = expr")

This makes it so that Pluto tries to import x from .mod before the module mod is defined. I suspect this is because Pluto wants to put all using statements first, but here it's apparently not realizing that the module needs to be defined before it can be used.

And yes, this is also an issue in Pluto, I just figured that since it was due to the dependancy tracker, that I should open the issue here, but I can move the issue there if you prefer.

[fonsp]

I think that mod should be seen as a reference of import .mod, it's currently not detected:

[fonsp]

(This is an issue with ExpressionExplorer)

[fonsp]

Let's implement it, and see if it breaks anything :)