Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PrettyTables rendering #36

Open
jpsamaroo opened this issue Aug 8, 2023 · 1 comment
Open

Add PrettyTables rendering #36

jpsamaroo opened this issue Aug 8, 2023 · 1 comment
Labels
good first issue Good for newcomers rendering

Comments

@jpsamaroo
Copy link
Member

As discussed at JuliaCon, it would be great to use PrettyTables to render the DTable via the show method.
@jpsamaroo jpsamaroo added good first issue Good for newcomers rendering labels Aug 8, 2023
@harsharora21 harsharora21 mentioned this issue Aug 14, 2023
Merged
jpsamaroo added a commit that referenced this issue Aug 18, 2023
@harsharora21 @jpsamaroo
Add PrettyTables rendering (#45)
4fa5d5b 
This PR adds PrettyTables rendering and resolves issue #36

## Example
```julia
julia> dt = DTable((a=[0,1,2,3,4,5,6,7,8,9], b=[0,1,2,3,4,5,6,7,8,9]), 10);

julia> dt
DTable with 1 partitions
Tabletype: NamedTuple
┌───────┬───────┐
│     a │     b │
│ Int64 │ Int64 │
├───────┼───────┤
│     0 │     0 │
│     1 │     1 │
│     2 │     2 │
│     3 │     3 │
│     4 │     4 │
│     5 │     5 │
│     6 │     6 │
│     7 │     7 │
│     8 │     8 │
│     9 │     9 │
└───────┴───────┘


julia> print(dt)
DTable with 1 partitions
Tabletype: NamedTuple
┌───────┬───────┐
│     a │     b │
│ Int64 │ Int64 │
├───────┼───────┤
│     0 │     0 │
│     1 │     1 │
│     2 │     2 │
│     3 │     3 │
│     4 │     4 │
│     5 │     5 │
│     6 │     6 │
│     7 │     7 │
│     8 │     8 │
│     9 │     9 │
└───────┴───────┘

```

---------

Co-authored-by: Julian Samaroo <[email protected]>
@krynju
Copy link
Member

krynju commented Oct 14, 2023

reverted #45
performance was weird and i was getting hangups locally

we need to reevaluate how to implement this correctly and possibly make it opt in instead of active by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers rendering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpsamaroo @krynju