Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify setproperties more precisely #11 #12

Merged
merged 2 commits into from
Oct 2, 2019
Merged

specify setproperties more precisely #11 #12

merged 2 commits into from
Oct 2, 2019

Conversation

jw3126
Copy link
Member

@jw3126 jw3126 commented Oct 1, 2019

close #11

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files           1        1           
  Lines          14       14           
=======================================
  Hits           13       13           
  Misses          1        1
Impacted Files Coverage Δ
src/ConstructionBase.jl 92.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee593e5...c549745. Read the comment docs.

Copy link
Member

@tkf tkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tkf
Copy link
Member

tkf commented Oct 1, 2019

BTW, should I go ahead merge PRs here and in Setfield if it doesn't say WIP?

@tkf tkf mentioned this pull request Oct 2, 2019
2 tasks
@jw3126
Copy link
Member Author

jw3126 commented Oct 2, 2019

I am a bit sloppy with annotating PRs WIP. I will try to do better. But yes if it LGTY feel free to merge it.

@jw3126 jw3126 merged commit 702347f into master Oct 2, 2019
@tkf
Copy link
Member

tkf commented Oct 2, 2019

I guess I can be sloppy too. Probably it's safer to say "merge if LGTY" (or maybe add a label). I'll do this too.

@tkf tkf deleted the spec branch October 2, 2019 05:46
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (ee593e5) to head (c549745).
Report is 180 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files           1        1           
  Lines          14       14           
=======================================
  Hits           13       13           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A bit more formal setproperties specification?
4 participants