-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify setproperties more precisely #11 #12
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 1 1
Lines 14 14
=======================================
Hits 13 13
Misses 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
BTW, should I go ahead merge PRs here and in Setfield if it doesn't say WIP? |
I am a bit sloppy with annotating PRs WIP. I will try to do better. But yes if it LGTY feel free to merge it. |
I guess I can be sloppy too. Probably it's safer to say "merge if LGTY" (or maybe add a label). I'll do this too. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 1 1
Lines 14 14
=======================================
Hits 13 13
Misses 1 1 ☔ View full report in Codecov by Sentry. |
close #11