Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle vector types more gracefully #209

Open
Kolaru opened this issue Nov 20, 2024 · 0 comments
Open

Handle vector types more gracefully #209

Kolaru opened this issue Nov 20, 2024 · 0 comments
Labels
enhancement v1.0

Comments

@Kolaru
Copy link
Collaborator

Kolaru commented Nov 20, 2024

Currently no check is performed to ensure consistency of vector types, mainly Vector and SVector (see #207).

I think that the return type of the function should be checked and the input interval should be converted accordingly.
Namely for roots(f, X)

  • f(X)::T, X::S -> convert X to T (typically T == SVector and X == Vector)

We could also check the jacobian, if it is given explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement v1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kolaru