Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNTuple] fix multi page reading for Index32/Index64 columns #315

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Mar 15, 2024

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.16%. Comparing base (a96f21e) to head (c7dfdef).

Files Patch % Lines
src/RNTuple/fieldcolumn_reading.jl 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   86.40%   86.16%   -0.25%     
==========================================
  Files          18       18              
  Lines        2450     2458       +8     
==========================================
+ Hits         2117     2118       +1     
- Misses        333      340       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moelf Moelf force-pushed the multi_page_index_read branch from 87585a6 to 834303d Compare March 15, 2024 16:48
@Moelf Moelf requested a review from tamasgal March 15, 2024 17:07
Copy link
Member

@tamasgal tamasgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, so far I can tell ;)


if cname == "ZL"
if cname == @SVector UInt8['Z', 'L']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comparisons look a bit weird but it is what it is ;) If we do such checks at more places in future, we should probably extract that or do some dispatch magic.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, and we have like 3 different such ifelse right now.

poly-Decompression is hard

@Moelf Moelf merged commit f6d62f5 into main Mar 15, 2024
8 of 10 checks passed
@Moelf Moelf deleted the multi_page_index_read branch March 15, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RNTuple] Wrong offset Index32/Index64 array when read from multiple pages
2 participants