Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more primitive (vector/jagged) leaf types #299

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

tamasgal
Copy link
Member

@tamasgal tamasgal commented Dec 20, 2023

Just a small PR which adds several vector/jagged primitive support for leaf types. This is a quick fix for #298

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d0628a9) 87.83% compared to head (584697b) 87.44%.

❗ Current head 584697b differs from pull request most recent head 11fa061. Consider uploading reports for the commit 11fa061 to get more accurate results

Files Patch % Lines
src/root.jl 62.50% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   87.83%   87.44%   -0.40%     
==========================================
  Files          18       18              
  Lines        2376     2389      +13     
==========================================
+ Hits         2087     2089       +2     
- Misses        289      300      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tamasgal
Copy link
Member Author

The reason for the incomplete coverage is the fact that I wanted to utilise some metaprogramming features to make it a bit more elegant and support all primitives... maybe this PR should be extended to cover them finally 🙈

@tamasgal
Copy link
Member Author

I added a few more...

@tamasgal tamasgal changed the title Add vector<unsigned int> support Add support for more primitive (vector/jagged) leaf types Dec 20, 2023
@tamasgal tamasgal merged commit 77b75d8 into main Dec 20, 2023
7 of 8 checks passed
@tamasgal tamasgal deleted the vector-uint-support branch December 20, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant