-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we fix images for darkmode? #39
Comments
idk if JupyterBook has equivalent of : https://github.blog/changelog/2021-11-24-specify-theme-context-for-images-in-markdown/ |
it must support theming by inspection, since looking at the actual HTML source reveals lines like: <img src="_static/juliaheplogo.png" class="logo__image only-light" alt="Logo image"/>
<script>document.write(`<img src="_static/juliaheplogo.png" class="logo__image only-dark" alt="Logo image"/>`);</script> so clearly some part of the Sphynx engine behind the scenes knows about the only-light and only-dark css classes... |
https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/branding.html is the Sphinx level documentation on this: I'll read it properly in the morning |
The tutorial looks pretty bad in dark mode as the images have white backgrounds.
Just adding an alpha channel isn't going to work as the images have black in them, which will become invisible.
I don't know if this easily fixable though as the Jupyterbook website has the same issues. There doesn't seem to be an easy option to force light mode.
The text was updated successfully, but these errors were encountered: