From c4efca0220682d4d9a2df1fbd50ebbe4eaa5bb8d Mon Sep 17 00:00:00 2001
From: Pere Mato <pere.mato@cern.ch>
Date: Tue, 20 Feb 2024 14:43:14 +0100
Subject: [PATCH] Added some fixes

---
 docs/src/api.md                                     |   8 ++++----
 .../FCC => docs/src/assets}/analysis_mH-recoil.pdf  | Bin
 docs/src/index.md                                   |   2 +-
 test/testRootReaderLegacy.jl                        |   8 +++-----
 4 files changed, 8 insertions(+), 10 deletions(-)
 rename {examples/FCC => docs/src/assets}/analysis_mH-recoil.pdf (100%)

diff --git a/docs/src/api.md b/docs/src/api.md
index e193946..272d537 100644
--- a/docs/src/api.md
+++ b/docs/src/api.md
@@ -5,13 +5,13 @@ Documentation for `EDM4hep.jl` public interface.
 ## Index - Types
 ```@index
 Pages   = ["api.md"]
-Modules = [EDM4hep, EDM4hep.RootIO]
+Modules = [EDM4hep, EDM4hep.RootIO, EDM4hep.Histograms]
 Order   = [:type]
 ```
 ## Index - Functions
 ```@index
 Pages   = ["api.md"]
-Modules = [EDM4hep, EDM4hep.RootIO]
+Modules = [EDM4hep, EDM4hep.RootIO, EDM4hep.Histograms]
 Order   = [:function]
 ```
 
@@ -24,12 +24,12 @@ Order = [:module]
 This is the list of all types defined for EDM4hep using the PODIO yaml file.
 
 ```@autodocs
-Modules = [EDM4hep, EDM4hep.RootIO]
+Modules = [EDM4hep, EDM4hep.RootIO, EDM4hep.Histograms]
 Order = [:type]
 ```
 ## Functions
 ```@autodocs
-Modules = [EDM4hep, EDM4hep.RootIO]
+Modules = [EDM4hep, EDM4hep.RootIO, EDM4hep.Histograms]
 Order = [:function]
 ```
 
diff --git a/examples/FCC/analysis_mH-recoil.pdf b/docs/src/assets/analysis_mH-recoil.pdf
similarity index 100%
rename from examples/FCC/analysis_mH-recoil.pdf
rename to docs/src/assets/analysis_mH-recoil.pdf
diff --git a/docs/src/index.md b/docs/src/index.md
index 5eb5c77..d53ef29 100644
--- a/docs/src/index.md
+++ b/docs/src/index.md
@@ -80,7 +80,7 @@ end
 ```
 ### examples/FCC/analysis_mH-recoil.jl
 This is basically the example `higgs/mH-recoil/mumu` from [FCCAnalyses](https://github.com/HEP-FCC/FCCAnalyses). It shows in a realistic manner hoe to develop analysis functions using the Data Types from EDM4hep to created high-level analysis functions. 
-The Jupyter notebook [analysis_mH-recoil.ipynb](../../examples/FCC/analysis_mH-recoil.pdf) shows the same example in form of a notebook. 
+The Jupyter notebook [analysis_mH-recoil.ipynb](./assets/analysis_mH-recoil.pdf) shows the same example in form of a notebook. 
 
 ## EDM4hep Data Model
 This is the diagram for the EDM4hep datamodel including relationships. 
diff --git a/test/testRootReaderLegacy.jl b/test/testRootReaderLegacy.jl
index a2a2e64..40af961 100644
--- a/test/testRootReaderLegacy.jl
+++ b/test/testRootReaderLegacy.jl
@@ -20,11 +20,9 @@ using EDM4hep.RootIO
         recps = RootIO.get(reader, evt, "ReconstructedParticles");
         tracks = RootIO.get(reader, evt, "EFlowTrack")
         pids  =  RootIO.get(reader, evt, "ParticleIDs")
-        if VERSION >= v"1.10"   # Seems to be working only for >= 1.10
-            muons = RootIO.get(reader, evt, "Muon#0")
-            if length(muons) == 2
-                @test abs(sum(muons.charge)) <= 2.0f0
-            end
+        muons = RootIO.get(reader, evt, "Muon#0", btype=ObjectID{ReconstructedParticle})
+        if length(muons) == 2
+            @test abs(sum(muons.charge)) <= 2.0f0
         end
     end