Allow DRef size to be nothing #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsamaroo
force-pushed
the
jps/size-skip
branch
2 times, most recently
from
c8210f9 to
3dde3a3
Compare
|
@quinnj this may be relevant for JuliaDB, since I believe it relies on |
Co-authored-by: Valentin Churavy <[email protected]>
|
We now have our own way to calculate object sizes in Dagger which are far more efficient than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of performing an expensive
Base.summarysizewhen calculating the size of arbitrary objects for storing as aDRef, we now set the size tonothingif we don't have a method for computingapprox_sizeof the object. This should alleviate performance concerns reported at JuliaParallel/Dagger.jl#204 (comment); I will post a matching Dagger PR soon to make use of this new change.@DrChainsaw this should be of interest to you!