Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell Adaptation of AddqBittorrentTrackers.sh for Windows Users #37

Closed
tyhallcsu opened this issue Sep 2, 2024 · 18 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tyhallcsu
Copy link

Hello @Jorman,

I wanted to reach out and share something that might be of interest to you and the community using your scripts.

PowerShell Adaptation

Inspired by your excellent AddqBittorrentTrackers.sh script, I've created a PowerShell adaptation specifically for Windows users. This script aims to provide similar functionality without requiring WSL or a Unix-like environment on Windows.

Key Points

  • The script is a direct adaptation of AddqBittorrentTrackers.sh for PowerShell.
  • It maintains core functionalities like connecting to qBittorrent's Web API, updating trackers, and handling private torrents.
  • Designed to be user-friendly for Windows users who might not be familiar with bash scripts.

GitHub Gist

You can find the PowerShell script here: qBittorrent Tracker Updater PowerShell Script

Offering for Inclusion

I'm offering this PowerShell version for potential inclusion in your repository. If you're interested, it could be a valuable addition for Windows users who want to use your tools without setting up a Unix-like environment.

Next Steps

If you're interested in including this in your repository:

  1. Feel free to review the script and suggest any modifications.
  2. Let me know if you'd like me to submit a pull request with the script.
  3. If you'd like, I can make any necessary adjustments before submission.

Acknowledgment

I am grateful for your original script, which has been incredibly useful and laid this adaptation's foundation.

Cheers

@Jorman
Copy link
Owner

Jorman commented Sep 10, 2024

Ciao @tyhallcsu
First let me thank you for your work and time on this.

From what I see it's a partial adaptation, that once launched performs a massive injection of trackers in every torrent present in qBittorrent. I would tell you that it's a good start and I would recommend you to go ahead, implementing at least the functionality related to the automatic recall from the various *Arr, but it's just my point of view, let's remember that often scripts and/or programs are born more for strictly personal needs, as it happened in my case, I was looking for something that would do what I wanted, I didn't find it and slowly I built it.

Thanks for sharing the project, so those looking for something related to Windows can have a place to start If you prefer go ahead and create a repository for the script, then maybe we put references to the scripts on the respective pages, i.e. those looking for a Windows version will see the link to your repository and those looking for the version for *nix will reinderize it this way, or if you want you can create a pull request dedicated to this script, it will stay with the others, obviously though if you want to update it you will have to make a pull request, or if I understand better how git works I can pull you in as a contributor for your file

@tyhallcsu
Copy link
Author

Yes, the adaption of your script was for a particular use case of my own.

  • It's almost certainly only a partial adaption.
  • I did not do any corner-case testing (or any testing, if I'm honest).
  • I needed a script that did this, and I adapted yours to my use case on the Windows platform.

If you like, I can create a repo, pull request, or whatever you'd like. Happy to help

@gggirlgeek
Copy link

THANK YOU, @tyhallcsu !!

The powershell script worked great. Appreciate you!

@Jorman
Copy link
Owner

Jorman commented Oct 6, 2024

Yes, the adaption of your script was for a particular use case of my own.

  • It's almost certainly only a partial adaption.
  • I did not do any corner-case testing (or any testing, if I'm honest).
  • I needed a script that did this, and I adapted yours to my use case on the Windows platform.

If you like, I can create a repo, pull request, or whatever you'd like. Happy to help

Glad is working!

Yes you can create a repo and is possible to make a mention on the main page, so is anyone is looking for a Windows adaptation, can land on your repo from here

@Jorman Jorman added enhancement New feature or request good first issue Good for newcomers labels Oct 6, 2024
@TH3F4LL3N
Copy link

image
i get this error everytime i use the powershell script. what did i do wrong ?

@Tmp341
Copy link

Tmp341 commented Nov 27, 2024

image i get this error everytime i use the powershell script. what did i do wrong ?

  • First, you need to enter your credentials inside the file:
    Script from Line 4 to Line 9
    • If you don't have them, you need to do it through your QBittorrent client's Web Interface tab.
  • Execute it with .\QBittorrentTrackerUpdater.ps1 Set-ExecutionPolicy RemoteSigned
    • I've set $clean_existing_trackers = $false to $true since on my first try, it made the list kinda messy.

@tyhallcsu
Copy link
Author

Oh lord, there is a lot of traffic suddenly on my personal adaptation of what @Jorman originally made. I shared what I made -- then shared for the community, but I don't think I can support updates :/

Yes, it's a partial-half adaptation of the original that suited my needs. But by no means is it great nor perfect.

@Tmp341
Copy link

Tmp341 commented Nov 27, 2024

Oh lord, there is a lot of traffic suddenly on my personal adaptation of what @Jorman originally made. I shared what I made -- then shared for the community, but I don't think I can support updates :/

Yes, it's a partial-half adaptation of the original that suited my needs. But by no means is it great nor perfect.

If you ask me, if you want to stop the traffic, create a PR for the original repo.

@tyhallcsu
Copy link
Author

tyhallcsu commented Nov 27, 2024

Oh lord, there is a lot of traffic suddenly on my personal adaptation of what @Jorman originally made. I shared what I made -- then shared for the community, but I don't think I can support updates :/
Yes, it's a partial-half adaptation of the original that suited my needs. But by no means is it great nor perfect.

If you ask me, if you want to stop the traffic, create a PR for the original repo.

I've used GitHub for years, but honestly, I have not contributed in that way; I'm not sure how. Would you be willing to show me how? I love to share my work, but I have never used it in a collaborative sense.

(Im embarrassed to admit)

@tyhallcsu
Copy link
Author

Another note: The work I have shared here is free for anyone to modify, redistribute, or otherwise use.
I don't even need attribution.

Copy + Paste and delete my name as author -- I don't care :) just sharing

@Tmp341
Copy link

Tmp341 commented Nov 27, 2024

I've used GitHub for years, but honestly, I have not contributed in that way; I'm not sure how. Would you be willing to show me how? I love to share my work, but I have never used it in a collaborative sense.

(Im embarrassed to admit)

Check this: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

Also created PR 41 for you. You can tell me if you need any editing. Or, just say so and i can close this PR if you want to create one yourself.

Tmp341 added a commit to Tmp341/Scripts that referenced this issue Nov 27, 2024
- Refer to [issue 37](Jorman#37) to see the original issue. I'm just doing PR.
@tyhallcsu
Copy link
Author

I've used GitHub for years, but honestly, I have not contributed in that way; I'm not sure how. Would you be willing to show me how? I love to share my work, but I have never used it in a collaborative sense.
(Im embarrassed to admit)

Check this: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

Also created PR 41 for you. You can tell me if you need any editing. Or, just say so and i can close this PR if you want to create one yourself.

#42

Did I do this correctly?

@tyhallcsu
Copy link
Author

Oh -- didnt see you create one first; I was trying myself -- again, I'm embarrassed to say idk how this whole thing works; this is my first time doing a PR since using GitGub

@tyhallcsu
Copy link
Author

@Tmp341 Thank you for helping! I see you created PR #41 to help me get my script into the repo.

Just to be clear - I attempted to create my own PR (#42) which includes the original script plus documentation (readme.md).

I'm still learning how to properly use GitHub for collaboration (this is my first PR ever of using GitHub!), so I really appreciate the guidance.

@Jorman, feel free to choose whichever PR works better for your repository structure. I'm happy to make any needed changes to either PR.

@Tmp341
Copy link

Tmp341 commented Nov 27, 2024

@Tmp341 Thank you for helping! I see you created PR #41 to help me get my script into the repo.

Just to be clear - I attempted to create my own PR (#42) which includes the original script plus documentation (readme.md).

I'm still learning how to properly use GitHub for collaboration (this is my first PR ever of using GitHub!), so I really appreciate the guidance.

@Jorman, feel free to choose whichever PR works better for your repository structure. I'm happy to make any needed changes to either PR.

Your's looks good. I will close mine for now.

@Jorman
Copy link
Owner

Jorman commented Dec 8, 2024

Hi guys,
it is not a problem to have a powershell script, indeed it extends the functionality to windows as well, however you have to "maintain" it and create any changes/adaptations based on the requests of the users who will use it. That's why I was recommending a different repo for the script, maybe though you can also collaborate with github, in fact definitely you can, but it's not like I'm very github savvy ;)

I am however considering a "different" option to make the script a bit more "universal", I just need to have some time to devote to it

In the meantime, would you like me to publish the script in powershell version?

@Tmp341
Copy link

Tmp341 commented Dec 9, 2024

In the meantime, would you like me to publish the script in powershell version?

I'm using a powershell script i kinda created for myself (by copying codes from here and there) and manually using it. The script here is good for windows users who want to get some public trackers without managing too much. But maybe you can create a better/modified one if you think so.

Jorman referenced this issue Jan 20, 2025
@Jorman
Copy link
Owner

Jorman commented Jan 20, 2025

I have published the Python version of the script, this should be enough to make the script cross-platform

@Jorman Jorman closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants