Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused argument in tudapub_title_page #10

Open
LukasManinger opened this issue Dec 22, 2024 · 2 comments
Open

Unused argument in tudapub_title_page #10

LukasManinger opened this issue Dec 22, 2024 · 2 comments

Comments

@LukasManinger
Copy link

Hi, thanks for your work!

The function tudpub-make-title-page takes title_height as an argument, however, it seems to me that this value is overridden later (without being used):

#let title_height = 3.5em //measure(title, styles).height

I guess this behavior is unintended. Simply deleting the mentioned line should solve the issue.

JeyRunner added a commit that referenced this issue Dec 28, 2024
@JeyRunner
Copy link
Owner

Thank you for pointing that out. I fixed it on master. If you need this fix soon, I can also publish a new version to universe. Otherwise I will wait for more changes until the next release.

@LukasManinger
Copy link
Author

Great!
Sure, I can wait; it's not urgent on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants