From ccdcbd79d16ca23dc7c66a5f56a1e86b487f9dab Mon Sep 17 00:00:00 2001 From: Shai Reznik Date: Thu, 10 Oct 2024 22:09:29 +0300 Subject: [PATCH 1/2] stlyed: Fixed typo in aria label on input --- packages/kit-styled/src/components/input/input.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kit-styled/src/components/input/input.tsx b/packages/kit-styled/src/components/input/input.tsx index 15fb6ae3f..72d00a827 100644 --- a/packages/kit-styled/src/components/input/input.tsx +++ b/packages/kit-styled/src/components/input/input.tsx @@ -14,7 +14,7 @@ export const Input = component$( (valueSig.value = el.value)) : onInput$} From d09f3026f50246ef601dc9fdd58ef0420c5d5424 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=AFeul?= <45822175+maiieul@users.noreply.github.com> Date: Thu, 10 Oct 2024 22:32:14 +0200 Subject: [PATCH 2/2] chore: remove all custom Icons in favor of Lucide icons (#986) --- .../src/components/code-copy/code-copy.tsx | 52 ++----------------- .../components/feature-list/feature-list.tsx | 10 ++-- apps/website/src/components/header/header.tsx | 12 ++--- apps/website/src/components/icons/Check.tsx | 19 ------- .../src/components/icons/ClipboardCheck.tsx | 14 ----- .../src/components/icons/CloseIcon.tsx | 11 ---- .../src/components/icons/CollapsibleIcon.tsx | 18 ------- .../website/src/components/icons/CopyIcon.tsx | 15 ------ apps/website/src/components/icons/Issues.tsx | 19 ------- .../website/src/components/icons/MenuIcon.tsx | 11 ---- .../website/src/components/icons/MoonIcon.tsx | 10 ---- apps/website/src/components/icons/Roadmap.tsx | 20 ------- apps/website/src/components/icons/SunIcon.tsx | 14 ----- .../src/components/icons/ThemeIcon.tsx | 17 ------ .../src/components/icons/double-chevron.tsx | 20 ------- 15 files changed, 11 insertions(+), 251 deletions(-) delete mode 100644 apps/website/src/components/icons/Check.tsx delete mode 100644 apps/website/src/components/icons/ClipboardCheck.tsx delete mode 100644 apps/website/src/components/icons/CloseIcon.tsx delete mode 100644 apps/website/src/components/icons/CollapsibleIcon.tsx delete mode 100644 apps/website/src/components/icons/CopyIcon.tsx delete mode 100644 apps/website/src/components/icons/Issues.tsx delete mode 100644 apps/website/src/components/icons/MenuIcon.tsx delete mode 100644 apps/website/src/components/icons/MoonIcon.tsx delete mode 100644 apps/website/src/components/icons/Roadmap.tsx delete mode 100644 apps/website/src/components/icons/SunIcon.tsx delete mode 100644 apps/website/src/components/icons/ThemeIcon.tsx delete mode 100644 apps/website/src/components/icons/double-chevron.tsx diff --git a/apps/website/src/components/code-copy/code-copy.tsx b/apps/website/src/components/code-copy/code-copy.tsx index 36e02a91d..ef8e905c9 100644 --- a/apps/website/src/components/code-copy/code-copy.tsx +++ b/apps/website/src/components/code-copy/code-copy.tsx @@ -2,6 +2,7 @@ import { PropsOf, component$, useSignal } from '@builder.io/qwik'; import { Button } from '~/components/ui'; import { cn } from '@qwik-ui/utils'; import copy from 'clipboard-copy'; +import { LuCheck, LuCopy } from '@qwikest/icons/lucide'; export type CodeCopyProps = PropsOf & { code?: string; @@ -13,7 +14,7 @@ export const CodeCopy = component$(({ code = '', ...props }) => { return ( ); }); - -export function CopyIcon(props: PropsOf<'svg'> & { color?: string }, key: string) { - return ( - - - - - ); -} - -export function ClipboardCheck(props: PropsOf<'svg'>, key: string) { - return ( - - - - ); -} diff --git a/apps/website/src/components/feature-list/feature-list.tsx b/apps/website/src/components/feature-list/feature-list.tsx index 6e276138c..ba10e2787 100644 --- a/apps/website/src/components/feature-list/feature-list.tsx +++ b/apps/website/src/components/feature-list/feature-list.tsx @@ -1,8 +1,6 @@ import { component$ } from '@builder.io/qwik'; -import { CheckIcon } from '../icons/Check'; -import { Roadmap } from '../icons/Roadmap'; -import { IssueIcon } from '../icons/Issues'; import { Note } from '../note/note'; +import { LuBadge, LuBadgeAlert, LuBadgeCheck } from '@qwikest/icons/lucide'; type FeatureListProps = { features: string[]; @@ -22,7 +20,7 @@ export const FeatureList = component$((props: FeatureListProps) => { key={descriptor} class={`flex w-full list-none items-center gap-x-2 gap-y-4 ${index === props.features.length - 1 ? '' : 'border-b-[1px]'} border-slate-200 py-2 dark:border-slate-800`} > - + {descriptor} ); @@ -39,7 +37,7 @@ export const FeatureList = component$((props: FeatureListProps) => { key={descriptor} class="flex w-full list-none items-center gap-x-2 gap-y-4 border-b-[1px] border-slate-200 py-2 dark:border-slate-800" > - + {descriptor} @@ -56,7 +54,7 @@ export const FeatureList = component$((props: FeatureListProps) => { key={descriptor} class="flex w-full list-none items-center gap-x-2 gap-y-4 border-b-[1px] border-slate-200 py-2 dark:border-slate-800" > - + {descriptor} diff --git a/apps/website/src/components/header/header.tsx b/apps/website/src/components/header/header.tsx index 5f4ed469a..5cabf5922 100644 --- a/apps/website/src/components/header/header.tsx +++ b/apps/website/src/components/header/header.tsx @@ -13,18 +13,14 @@ import { useLocation } from '@builder.io/qwik-city'; // eslint-disable-next-line @nx/enforce-module-boundaries // eslint-disable-next-line @nx/enforce-module-boundaries import { version as styledKitVersion } from '../../../../../packages/kit-styled/package.json'; -import { CloseIcon } from '../icons/CloseIcon'; import { GitHubIcon } from '../icons/GitHubIcon'; -import { MenuIcon } from '../icons/MenuIcon'; -import { MoonIcon } from '../icons/MoonIcon'; -import { SunIcon } from '../icons/SunIcon'; import { LogoIcon, LogoWithBorders } from '../icons/logo'; import { useTheme } from '@qwik-ui/themes'; import { Modal } from '@qwik-ui/headless'; import { useAppState } from '~/_state/use-app-state'; -import { LuX } from '@qwikest/icons/lucide'; +import { LuMenu, LuMoon, LuSun, LuX } from '@qwikest/icons/lucide'; import { DocsNavigation } from '../navigation-docs/navigation-docs'; import { useKitMenuItems } from '~/routes/layout'; import { cn } from '@qwik-ui/utils'; @@ -193,7 +189,7 @@ export default component$(({ showVersion = false }: HeaderProps) => { look="ghost" class="flex lg:hidden" > - {isSidebarOpenedSig.value ? : } + @@ -243,10 +239,10 @@ const DarkModeToggle = component$>(({ ...props }) => { } >
- +
); diff --git a/apps/website/src/components/icons/Check.tsx b/apps/website/src/components/icons/Check.tsx deleted file mode 100644 index 26f069908..000000000 --- a/apps/website/src/components/icons/Check.tsx +++ /dev/null @@ -1,19 +0,0 @@ -import { PropsOf } from '@builder.io/qwik'; - -export function CheckIcon(props: PropsOf<'svg'>, key: string) { - return ( - - - - - - - ); -} diff --git a/apps/website/src/components/icons/ClipboardCheck.tsx b/apps/website/src/components/icons/ClipboardCheck.tsx deleted file mode 100644 index cfa50978c..000000000 --- a/apps/website/src/components/icons/ClipboardCheck.tsx +++ /dev/null @@ -1,14 +0,0 @@ -export const ClipboardCheck = () => ( - - - - - -); diff --git a/apps/website/src/components/icons/CloseIcon.tsx b/apps/website/src/components/icons/CloseIcon.tsx deleted file mode 100644 index 050bf4922..000000000 --- a/apps/website/src/components/icons/CloseIcon.tsx +++ /dev/null @@ -1,11 +0,0 @@ -export const CloseIcon = () => ( - -); diff --git a/apps/website/src/components/icons/CollapsibleIcon.tsx b/apps/website/src/components/icons/CollapsibleIcon.tsx deleted file mode 100644 index d651be6aa..000000000 --- a/apps/website/src/components/icons/CollapsibleIcon.tsx +++ /dev/null @@ -1,18 +0,0 @@ -import { PropsOf } from '@builder.io/qwik'; - -export function CollapsibleIcon(props: PropsOf<'svg'>) { - return ( - - - - ); -} diff --git a/apps/website/src/components/icons/CopyIcon.tsx b/apps/website/src/components/icons/CopyIcon.tsx deleted file mode 100644 index f5f67caea..000000000 --- a/apps/website/src/components/icons/CopyIcon.tsx +++ /dev/null @@ -1,15 +0,0 @@ -export const CopyIcon = () => ( - - - -); diff --git a/apps/website/src/components/icons/Issues.tsx b/apps/website/src/components/icons/Issues.tsx deleted file mode 100644 index fe51305e2..000000000 --- a/apps/website/src/components/icons/Issues.tsx +++ /dev/null @@ -1,19 +0,0 @@ -import { PropsOf } from '@builder.io/qwik'; - -export function IssueIcon(props: PropsOf<'svg'>, key: string) { - return ( - - - - - - - ); -} diff --git a/apps/website/src/components/icons/MenuIcon.tsx b/apps/website/src/components/icons/MenuIcon.tsx deleted file mode 100644 index e7d762c42..000000000 --- a/apps/website/src/components/icons/MenuIcon.tsx +++ /dev/null @@ -1,11 +0,0 @@ -export const MenuIcon = () => ( - -); diff --git a/apps/website/src/components/icons/MoonIcon.tsx b/apps/website/src/components/icons/MoonIcon.tsx deleted file mode 100644 index 8427abb8a..000000000 --- a/apps/website/src/components/icons/MoonIcon.tsx +++ /dev/null @@ -1,10 +0,0 @@ -export const MoonIcon = () => ( - -); diff --git a/apps/website/src/components/icons/Roadmap.tsx b/apps/website/src/components/icons/Roadmap.tsx deleted file mode 100644 index caff63818..000000000 --- a/apps/website/src/components/icons/Roadmap.tsx +++ /dev/null @@ -1,20 +0,0 @@ -import type { QwikIntrinsicElements } from '@builder.io/qwik'; - -export function Roadmap(props: QwikIntrinsicElements['svg'], key: string) { - return ( - - - - - - - ); -} -export default Roadmap; diff --git a/apps/website/src/components/icons/SunIcon.tsx b/apps/website/src/components/icons/SunIcon.tsx deleted file mode 100644 index d8cb3f0d1..000000000 --- a/apps/website/src/components/icons/SunIcon.tsx +++ /dev/null @@ -1,14 +0,0 @@ -export const SunIcon = () => ( - -); diff --git a/apps/website/src/components/icons/ThemeIcon.tsx b/apps/website/src/components/icons/ThemeIcon.tsx deleted file mode 100644 index beb404364..000000000 --- a/apps/website/src/components/icons/ThemeIcon.tsx +++ /dev/null @@ -1,17 +0,0 @@ -export const ThemeIcon = () => ( - - - -); diff --git a/apps/website/src/components/icons/double-chevron.tsx b/apps/website/src/components/icons/double-chevron.tsx deleted file mode 100644 index 0ea9f5570..000000000 --- a/apps/website/src/components/icons/double-chevron.tsx +++ /dev/null @@ -1,20 +0,0 @@ -import { PropsOf } from '@builder.io/qwik'; - -export function DoubleChevron(props: PropsOf<'svg'>, key: string) { - return ( - - - - ); -}