From 4cd80e0ed532a4047b943f53e1ca9281b6b9c101 Mon Sep 17 00:00:00 2001 From: Nathan Baltzell Date: Fri, 1 Nov 2024 13:34:10 -0400 Subject: [PATCH 1/9] add linting ci --- .github/workflows/linting.yml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/workflows/linting.yml diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml new file mode 100644 index 0000000..ca17f79 --- /dev/null +++ b/.github/workflows/linting.yml @@ -0,0 +1,21 @@ +name: Validation-latest + +on: + pull_request: + push: + branches: [ main ] + tags: [ '*' ] + workflow_dispatch: + +jobs: + linting: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-python@v5 + - name: json + run: python3 -c 'import json ; print(json.load(open("setup.json")))' + - name: yaml + run: python3 -c 'import yaml ; yaml.unsafe_load("\n".join(open("coatjava/10.1.1/clas12-default.yaml").readlines()))' +# - name: xml +# run: xmllint From 70d6ccf07122c49d0425603ed46187ef5b0b614b Mon Sep 17 00:00:00 2001 From: Nathan Baltzell Date: Fri, 1 Nov 2024 13:37:33 -0400 Subject: [PATCH 2/9] add xml --- .github/workflows/linting.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index ca17f79..d9f9b21 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -13,9 +13,11 @@ jobs: steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v5 + - uses: actions/setup-xmllint@v5 + - uses: Bpolitycki/setup-xmllint-action@1.0.1 - name: json run: python3 -c 'import json ; print(json.load(open("setup.json")))' - name: yaml - run: python3 -c 'import yaml ; yaml.unsafe_load("\n".join(open("coatjava/10.1.1/clas12-default.yaml").readlines()))' -# - name: xml -# run: xmllint + run: python3 -c 'import yaml ; print(yaml.unsafe_load("\n".join(open("coatjava/10.1.1/clas12-default.yaml").readlines())))' + - name: xml + run: xmllint From 0680a3428d4114bf888bb92d9507399ede934e1f Mon Sep 17 00:00:00 2001 From: Nathan Baltzell Date: Fri, 1 Nov 2024 13:38:33 -0400 Subject: [PATCH 3/9] add xml --- .github/workflows/linting.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index d9f9b21..a04ce4e 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -13,7 +13,6 @@ jobs: steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v5 - - uses: actions/setup-xmllint@v5 - uses: Bpolitycki/setup-xmllint-action@1.0.1 - name: json run: python3 -c 'import json ; print(json.load(open("setup.json")))' From 8c2d26c5bd61a17882e1608d2c32841d7c044b29 Mon Sep 17 00:00:00 2001 From: Nathan Baltzell Date: Fri, 1 Nov 2024 13:42:08 -0400 Subject: [PATCH 4/9] loop --- .github/workflows/linting.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index a04ce4e..5138fbd 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -15,8 +15,8 @@ jobs: - uses: actions/setup-python@v5 - uses: Bpolitycki/setup-xmllint-action@1.0.1 - name: json - run: python3 -c 'import json ; print(json.load(open("setup.json")))' + run: find . -name '*.json' -exec python3 -c 'import json ; print(json.load(open("{}")))'\; - name: yaml - run: python3 -c 'import yaml ; print(yaml.unsafe_load("\n".join(open("coatjava/10.1.1/clas12-default.yaml").readlines())))' + run: find . -name '*.yaml' -exec python3 -c 'import yaml ; print(yaml.unsafe_load("\n".join(open("{}").readlines())))' \; - name: xml - run: xmllint + run: find . -name '*.xml' -exec xmllint {} \; From 14848ea16ab0cb0fe706c1df2513b3470df652f0 Mon Sep 17 00:00:00 2001 From: Nathan Baltzell Date: Fri, 1 Nov 2024 13:43:07 -0400 Subject: [PATCH 5/9] fix syntax --- .github/workflows/linting.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 5138fbd..ef72211 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -15,7 +15,7 @@ jobs: - uses: actions/setup-python@v5 - uses: Bpolitycki/setup-xmllint-action@1.0.1 - name: json - run: find . -name '*.json' -exec python3 -c 'import json ; print(json.load(open("{}")))'\; + run: find . -name '*.json' -exec python3 -c 'import json ; print(json.load(open("{}")))' \; - name: yaml run: find . -name '*.yaml' -exec python3 -c 'import yaml ; print(yaml.unsafe_load("\n".join(open("{}").readlines())))' \; - name: xml From 5ce7ae4874fccbe7f09154e3319c7851e84bde89 Mon Sep 17 00:00:00 2001 From: Nathan Baltzell Date: Fri, 1 Nov 2024 13:44:19 -0400 Subject: [PATCH 6/9] really find gcards --- .github/workflows/linting.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index ef72211..123ce5c 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -19,4 +19,4 @@ jobs: - name: yaml run: find . -name '*.yaml' -exec python3 -c 'import yaml ; print(yaml.unsafe_load("\n".join(open("{}").readlines())))' \; - name: xml - run: find . -name '*.xml' -exec xmllint {} \; + run: find . -name '*.gcard' -exec xmllint {} \; From c053b906ae32f83cbde0b39df2f962625a5fe429 Mon Sep 17 00:00:00 2001 From: Nathan Baltzell Date: Fri, 1 Nov 2024 13:53:52 -0400 Subject: [PATCH 7/9] fix name --- .github/workflows/linting.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 123ce5c..21ce337 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -1,4 +1,4 @@ -name: Validation-latest +name: Linting on: pull_request: From 31f6da1cdeefd9745a5b55b9d53a3871338eb232 Mon Sep 17 00:00:00 2001 From: Nathan Baltzell Date: Fri, 1 Nov 2024 18:19:00 -0400 Subject: [PATCH 8/9] propagate exit codes --- .github/workflows/linting.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 21ce337..9cf54f5 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -15,8 +15,8 @@ jobs: - uses: actions/setup-python@v5 - uses: Bpolitycki/setup-xmllint-action@1.0.1 - name: json - run: find . -name '*.json' -exec python3 -c 'import json ; print(json.load(open("{}")))' \; + run: find . -name '*.json' -printf 'import json ; print(json.load(open("%p")))\n' | xargs -0 python3 -c - name: yaml - run: find . -name '*.yaml' -exec python3 -c 'import yaml ; print(yaml.unsafe_load("\n".join(open("{}").readlines())))' \; + run: find . -name '*.yaml' -printf 'import yaml ; print(yaml.unsafe_load("\n".join(open("%p").readlines())))' | xargs -0 python3 -c - name: xml - run: find . -name '*.gcard' -exec xmllint {} \; + run: find . -name '*.gcard' | xargs xmllint From 99c2f016f350c012e5649df23501b323edb9e0e8 Mon Sep 17 00:00:00 2001 From: Nathan Baltzell Date: Fri, 1 Nov 2024 18:23:50 -0400 Subject: [PATCH 9/9] bugfix --- .github/workflows/linting.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 9cf54f5..1926f6b 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -12,11 +12,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: actions/setup-python@v5 - uses: Bpolitycki/setup-xmllint-action@1.0.1 - name: json run: find . -name '*.json' -printf 'import json ; print(json.load(open("%p")))\n' | xargs -0 python3 -c - name: yaml - run: find . -name '*.yaml' -printf 'import yaml ; print(yaml.unsafe_load("\n".join(open("%p").readlines())))' | xargs -0 python3 -c + run: find . -name '*.yaml' -printf 'import yaml ; print(yaml.unsafe_load("".join(open("%p").readlines())))\n' | xargs -0 python3 -c - name: xml run: find . -name '*.gcard' | xargs xmllint